Date: Sat, 17 Dec 2016 18:17:01 +0100 From: Thomas Zander <riggs@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r428763 - in head/audio/fluidsynth: . files Message-ID: <CAFU734yh2pbehwdt=97j6fsO6DSDYOj8zhPcBduT-kS8XR2-ng@mail.gmail.com> In-Reply-To: <b3f806e2-9410-7853-f762-fa17cf6022b6@FreeBSD.org> References: <201612171341.uBHDfWIF098306@repo.freebsd.org> <8e01a684-eef8-a3ab-1cea-757db5879feb@FreeBSD.org> <CAFU734wwRb2iK11vUYmK=6qwg3qJBuwesJoMt-pbhE7BRqqRNQ@mail.gmail.com> <b3f806e2-9410-7853-f762-fa17cf6022b6@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17 December 2016 at 18:00, Mathieu Arnold <mat@freebsd.org> wrote:
> Le 17/12/2016 =C3=A0 17:38, Thomas Zander a =C3=A9crit :
>> On 17 December 2016 at 14:50, Mathieu Arnold <mat@freebsd.org> wrote:
>>> Le 17/12/2016 =C3=A0 14:41, Thomas Zander a =C3=A9crit :
>>>> Modified: head/audio/fluidsynth/Makefile
>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>>> --- head/audio/fluidsynth/Makefile Sat Dec 17 13:26:05 2016 =
(r428762)
>>>> +++ head/audio/fluidsynth/Makefile Sat Dec 17 13:41:32 2016 =
(r428763)
>>>> @@ -13,7 +13,7 @@ COMMENT=3D Real-time software synthesizer
>>>> LICENSE=3D LGPL20
>>>> LICENSE_FILE=3D ${WRKSRC}/COPYING
>>>>
>>>> -OPTIONS_DEFINE=3D JACK ALSA DBUS LADSPA LASH PORTAUDIO PULSEAUDI=
O SNDFILE
>>>> +OPTIONS_DEFINE=3D JACK ALSA DBUS LADSPA LASH PORTAUDIO PULSEAUDI=
O SNDFILE SNDIO
>>>> OPTIONS_DEFAULT=3D JACK
>>> This is missing a PORTREVISION bump.
>> Since when? The new SNDIO knob is disabled by default and the default
>> package remains unchanged.
>
> First, because, well, it is the rule[1]. You changed the options list,
> so the package can change, so it must be bumped.
Thanks for pointing to the doc. However, I specifically remember
discussions about NOT bumping in case the default package remains
unchanged, the goal being to avoid futile rebuild of packages. That
was the rationale for not bumping. But if it's the rule, sure, don't
want to break any laws here :-)
> Second, because if I had built this port before you added the option,
> and I had sndio installed, it would be linked with it but there would
> not be a dependency recorded. But if I build it after this option is
> added, it is not liked with SNDIO any more. Which makes a different
> package, which is a big reason for bumping PORTREVISION.
That's incorrect. The patch brings in not only the cmake args but the
whole sndio output module. fluidsynth before this commit would never
link to sndio. So this would have not been a problem at all.
Best regards
Riggs
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFU734yh2pbehwdt=97j6fsO6DSDYOj8zhPcBduT-kS8XR2-ng>