Date: Tue, 15 May 2012 21:27:47 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r235480 - in stable/9/sys: dev/usb geom geom/mountver i386/conf kern sys Message-ID: <20120515182747.GD2358@deviant.kiev.zoral.com.ua> In-Reply-To: <201205151721.q4FHLlgq097452@svn.freebsd.org> References: <201205151721.q4FHLlgq097452@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--8w3uRX/HFJGApMzv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 15, 2012 at 05:21:47PM +0000, Andriy Gapon wrote: > Author: avg > Date: Tue May 15 17:21:46 2012 > New Revision: 235480 > URL: http://svn.freebsd.org/changeset/base/235480 >=20 > Log: > MFC r230643: stop_scheduler -> td_stopsched > Modified: stable/9/sys/sys/proc.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- stable/9/sys/sys/proc.h Tue May 15 17:11:00 2012 (r235479) > +++ stable/9/sys/sys/proc.h Tue May 15 17:21:46 2012 (r235480) > @@ -235,6 +235,7 @@ struct thread { > short td_locks; /* (k) Count of non-spin locks. */ > short td_rw_rlocks; /* (k) Count of rwlock read locks. */ > short td_lk_slocks; /* (k) Count of lockmgr shared locks. */ > + short td_stopsched; /* (k) Scheduler stopped. */ > struct turnstile *td_blocked; /* (t) Lock thread is blocked on. */ > const char *td_lockname; /* (t) Name of lock blocked on. */ > LIST_HEAD(, turnstile) td_contested; /* (q) Contested locks. */ >=20 Did you verified that there is a gap between td_lk_slocks and td_blocked an all tier-1 architectures large enough to adopt td_stopsched without changing the layout of struct thread after the new member ? If not, this breaks KBI. --8w3uRX/HFJGApMzv Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+yoCIACgkQC3+MBN1Mb4jRtgCgh0qMHEc1PgHHB/P5tTb+i5aj AIUAoOyGgjvsGSMppqmFoqnjC6g/fGXV =TfIt -----END PGP SIGNATURE----- --8w3uRX/HFJGApMzv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120515182747.GD2358>