Date: Tue, 6 Jun 2006 08:40:46 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom geom.h geom_io.c Message-ID: <20060606064046.GB72060@garage.freebsd.pl> In-Reply-To: <25334.1149569429@critter.freebsd.dk> References: <200606052113.k55LDMks055707@repoman.freebsd.org> <25334.1149569429@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Jun 06, 2006 at 06:50:29AM +0200, Poul-Henning Kamp wrote: +> In message <200606052113.k55LDMks055707@repoman.freebsd.org>, Pawel Jakub Dawid +> ek writes: +> +> > Add g_duplicate_bio() function which does the same thing what g_clone_bio() +> > is doing, but g_duplicate_bio() allocates new bio with M_WAITOK flag. +> +> First, this sounds wrong to me from an overall memory management point +> of view. +> +> Second, g_clone_bio_wait() had been a better name. I thought so too when you added g_alloc_bio() function (a M_WAITOK version of g_new_bio())... :) -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFEhSNuForvXbEpPzQRAsLTAKC7cKwmpEkWQLPxKWpOP5jiYUoG8wCdGBDE uqjIPNTSVEy3TQeYTDj3BM0= =9rcR -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060606064046.GB72060>