Date: Thu, 20 Aug 1998 19:52:33 +1000 From: Bruce Evans <bde@zeta.org.au> To: freebsd-current@FreeBSD.ORG, roberto@eurocontrol.fr Subject: Re: Problem with Poul-Henning's commit in /etc/rc Message-ID: <199808200952.TAA21251@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>Unless I'm mistaken, the latest change from Poul-Henning to /etc/rc is bad >because failures are not detected anymore. The $? check is now after the >"echo" and will check its return code, not the one from mount. Another point on the hat: the echoes are attached to the wrong mount command. There is no error checking for the nfs mount, so the echoes wouldn't harm the status if they were correctly placed. Bruce >Index: rc >=================================================================== >RCS file: /home/ncvs/src/etc/rc,v >retrieving revision 1.148 >retrieving revision 1.149 >diff -u -2 -u -r1.148 -r1.149 >--- rc 1998/08/10 19:53:50 1.148 >+++ rc 1998/08/14 06:49:05 1.149 >@@ -77,5 +77,7 @@ > umount -a >/dev/null 2>&1 > >+echo -n "Mounting NFS file systems" > mount -a -t nonfs >+echo . > if [ $? != 0 ]; then > echo "Filesystem mount failed, startup aborted" > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808200952.TAA21251>