Date: Thu, 16 Apr 2020 11:13:36 -0700 (PDT) From: "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net> To: Eugene Grosbein <eugen@grosbein.net> Cc: Poul-Henning Kamp <phk@phk.freebsd.dk>, freebsd-hackers@freebsd.org, Wojciech Puchar <wojtek@puchar.net> Subject: Re: fsck parallel check Message-ID: <202004161813.03GIDa7K047015@gndrsh.dnsmgr.net> In-Reply-To: <2126559d-38d8-8a95-d0d1-53a4f79fde65@grosbein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> 16.04.2020 23:59, Poul-Henning Kamp wrote: > > > -------- > > In message <571d8b81-f4f9-d371-6cf2-2e7aeb82a09b@grosbein.net>, Eugene Grosbein writes: > > > >> Not necessary. Fsck tries to parse device name this way: /path/to/nameNUMBERrest > >> so it skips all chars upto last /, then extracts "name" part not containing any digits, > >> then extracts NUMBER part containing only digits, upto maximum lenght. > >> Then is uses nameNUMBER for "disk name". > > > > Yeah, that part sucks... > > > > I think it would make sense to make the heuristic that if there are any > > entries with pass > 2, then ignore the "disk name" and simply run all > > entries for each pass number in parallel, trusting root to have it > > figured out. > > > > If the highest passnumber is 2, retain the "disk name" heuristic. > > I like it. Consider my semi-silence a "no objection here". -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004161813.03GIDa7K047015>