Date: Tue, 1 May 2018 13:22:05 -0500 From: Kyle Evans <kevans@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: David Cross <dcrosstech@gmail.com>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, Devin Teske <dteske@freebsd.org> Subject: Re: Bug 207069 (loader password kills boot) Message-ID: <CACNAnaGmHK1WoXHX2rvJR=50p%2B1gX72M7%2BM-KH5YzET=e48_UQ@mail.gmail.com> In-Reply-To: <CANCZdfr0pRiN08ZVn%2B2x%2BTk6suAbkg7Ui_X-9S=E14WfqDFMYg@mail.gmail.com> References: <7630266D-D078-41B3-BC27-32EBF65540C4@gmail.com> <CACNAnaEEd_DoJg_9B=Y2GuL=R40ShTA27fgXis3jMiSgVdN9-A@mail.gmail.com> <CANCZdfr0pRiN08ZVn%2B2x%2BTk6suAbkg7Ui_X-9S=E14WfqDFMYg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 1, 2018 at 1:17 PM, Warner Losh <imp@bsdimp.com> wrote: > > > On Tue, May 1, 2018 at 12:12 PM, Kyle Evans <kevans@freebsd.org> wrote: >> >> On Tue, May 1, 2018 at 1:07 PM, David Cross <dcrosstech@gmail.com> wrote: >> > The aforementioned bug has been open for over 2 years, with attached and >> > tested patches. At least one other has commented. >> > >> > Could we please have it for 11.2/12.0? >> >> Hi, >> >> CC'ing Devin, our local Forth-fu-fighter. If it looks ok to Devin, one >> of us should go ahead and shuffle this through. > > > Yes. I've looked at this code a fair amount, and I don't understand why this > is needed and why it would make things work. Since it is a security thing, > I'm very reluctant to push it in absent better understanding of why it > works. > Right, it also confuses me. =) When I was implementing this stuff for Lua, autoboot DTRT as long as module_path is setup correctly -- this is probably the part that's missing since IIRC that's usually done in menu setup (that doesn't happen here). I'm not sure if this the right way to fix it in Forth-land, though.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaGmHK1WoXHX2rvJR=50p%2B1gX72M7%2BM-KH5YzET=e48_UQ>