Date: Tue, 24 Sep 2019 20:35:24 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 240798] nvmecontrol perftest is broken Message-ID: <bug-240798-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240798 Bug ID: 240798 Summary: nvmecontrol perftest is broken Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: stefanrink@yahoo.com Recent changes in perftest.c /sbin/nvmecontrol/perftest.c have broken the tool. The settings for the test (threads, size) are not set into the ioctl struct and there is check failure where you always need to add -f something or else it wil not accept your parameters. --- /sbin/nvmecontrol/perftest.c 146c146 < if (opt.flags == NULL || opt.op == NULL) --- > if (opt.op == NULL) 148c148 < if (strcmp(opt.flags, "refthread") == 0) --- > if (opt.flags != NULL && strcmp(opt.flags, "refthread") == 0) 165a166,167 > io_test.num_threads = opt.threads; > 173a176,181 > if (opt.size < 0){ > fprintf(stderr, "Invalid size.\n"); > arg_help(argc, argv, f); > } > > io_test.size=opt.size; -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240798-227>
