Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Feb 2026 17:10:31 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 288345] poudriere run, hanging umounts, system fails to reboot due to hanging processes
Message-ID:  <bug-288345-227-HcPf5v4R8l@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-288345-227@https.bugs.freebsd.org/bugzilla/>

index | next in thread | previous in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288345

--- Comment #47 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=8b64d46fab87af3ae062901312187f3a04ad2d67

commit 8b64d46fab87af3ae062901312187f3a04ad2d67
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2026-02-25 15:31:30 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2026-02-25 15:31:30 +0000

    nullfs: Fix handling of doomed vnodes in nullfs_unlink_lowervp()

    nullfs_unlink_lowervp() is called with the lower vnode locked, so the
    nullfs vnode is locked too.  The following can occur:
    1. the vunref() call decrements the usecount 2->1,
    2. a different thread calls vrele() on the vnode, decrements the
       usecount 0->1, then blocks on the vnode lock,
    3. the first thread tests vp->v_usecount == 0 and observes that it is
       true,
    4. the first thread incorrectly unlocks the lower vnode.

    Fix this by testing VN_IS_DOOMED directly.  Since
    nullfs_unlink_lowervp() holds the vnode lock, the value of the
    VIRF_DOOMED flag is stable.

    Thanks to leres@ for patiently helping to track this down.

    PR:             288345
    MFC after:      1 week
    Reviewed by:    kib
    Differential Revision:  https://reviews.freebsd.org/D55446

 sys/fs/nullfs/null_vfsops.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-288345-227-HcPf5v4R8l>