Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Feb 2025 00:29:46 GMT
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 07324ed40901 - stable/14 - crtbegin: accurately check for the end of .dtors
Message-ID:  <202502040029.5140TkTs097397@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=07324ed409012746c2b6ea4c06f00d39721c2378

commit 07324ed409012746c2b6ea4c06f00d39721c2378
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2025-01-27 19:21:20 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2025-02-04 00:28:37 +0000

    crtbegin: accurately check for the end of .dtors
    
    (cherry picked from commit 6ee34bca48a9e0867d46b24a78855e225d46ddda)
---
 lib/csu/common/crtbegin.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib/csu/common/crtbegin.c b/lib/csu/common/crtbegin.c
index ddeec986a431..da6cdf14d47e 100644
--- a/lib/csu/common/crtbegin.c
+++ b/lib/csu/common/crtbegin.c
@@ -67,19 +67,27 @@ static crt_func __DTOR_LIST__[] __section(".dtors") __used = {
 	(crt_func)-1
 };
 
+extern const char startof_dtors[] __asm(".startof..dtors")
+    __weak_symbol __hidden;
+extern const char sizeof_dtors[] __asm(".sizeof..dtors")
+    __weak_symbol __hidden;
+
 static void
 __do_global_dtors_aux(void)
 {
 	crt_func fn;
+	uintptr_t dtors_end;
 	int n;
 
 #ifdef SHARED
 	run_cxa_finalize();
 #endif
 
+	dtors_end = (uintptr_t)&startof_dtors + (uintptr_t)&sizeof_dtors;
 	for (n = 1;; n++) {
 		fn = __DTOR_LIST__[n];
-		if (fn == (crt_func)0 || fn == (crt_func)-1)
+		if (fn == (crt_func)0 || fn == (crt_func)-1 || (dtors_end > 0 &&
+		    (uintptr_t)&__DTOR_LIST__[n] >= dtors_end))
 			break;
 		fn();
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502040029.5140TkTs097397>