Date: Tue, 31 Aug 2004 09:08:53 +0400 From: Yar Tikhiy <yar@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/mbr Makefile mbr.s Message-ID: <20040831050853.GA75766@comp.chem.msu.su> In-Reply-To: <200408301141.00176.jhb@FreeBSD.org> References: <200408280839.i7S8dZpI097103@repoman.freebsd.org> <200408301141.00176.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 30, 2004 at 11:41:00AM -0400, John Baldwin wrote:
> On Saturday 28 August 2004 04:39 am, Yar Tikhiy wrote:
> > yar 2004-08-28 08:39:35 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> > sys/boot/i386/mbr Makefile mbr.s
> > Log:
> > Don't be too smart, just try packet mode of INT13 first.
> > This way of operation is more robust than the "AI" used
> > before.
> >
> > Add flags to mbr accessible from make.conf as BOOT_MBR_FLAGS.
> > Only one flag is defined now, "allow using packet mode", which
> > is 0x80 in accord with the rest of i386 boot code. The "packet"
> > flag is on by default.
> >
> > PR: i386/70241
> > Submitted by: Valentin Nechayev <netch <@> netch.kiev.ua> (inital
> > version) Discussed with: jhb (by Valentin Nechayev)
> > Tested on: bochs (with EDD turned on or off by patching the BIOS),
> > PCs
> >
> > Revision Changes Path
> > 1.14 +4 -0 src/sys/boot/i386/mbr/Makefile
> > 1.7 +6 -6 src/sys/boot/i386/mbr/mbr.s
>
> Hmm, there are no e-mails from me in the PR trail and I don't recall ever be
> in favor of these changes (though I don't care enough to ask for them to be
> backed out.. Only really old machines with pre-1995 BIOS should be broken in
> theory.) It would be nice if you wouldn't claim that I supported something
> that I didn't actually support though.
John, I try to believe people as much as possible since that saves
my time, and I believe Valentin Nechayev particularly because I know
him quite well. Here are his words straight from the PR:
%%%
>Fix:
Revert logic of selection between traditional and EDD reading mode
to one which prefers EDD if available (as was in the same file in revisions
1.11 and 1.12). This is supported by John Baldwin (private conversation
after thread in hackers@):
==={{{
The problem is that there are BIOS's out there that claim to support EDD but
still don't work correctly. I don't remember all the details at this point,
but I think it had to do with sysinstall not always being in sync with the
BIOS about how sectors were in a cylinder. I guess though we could just turn
EDD on by default in 5.x or perhaps 6.0. 5.x doesn't really run well on a
386 or even a 486, and that is the class of machine that has problems with
EDD.
===}}}
%%%
I know it could be hard on memory to return to issues one used to
work at in the past, so I decided not to bother you to confirm if
that quote is actually yours. Please excuse me if it was a poor
idea of mine.
--
Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040831050853.GA75766>