Date: Tue, 21 Jul 2009 09:33:23 -0400 From: John Baldwin <jhb@freebsd.org> To: obrien@freebsd.org Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r195696 - in stable/7: crypto/openssh secure/lib/libssh Message-ID: <200907210933.24176.jhb@freebsd.org> In-Reply-To: <20090721040810.GA84807@dragon.NUXI.org> References: <200907142046.n6EKkJwO070823@svn.freebsd.org> <20090721040810.GA84807@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 21 July 2009 12:08:10 am David O'Brien wrote: > On Tue, Jul 14, 2009 at 08:46:19PM +0000, John Baldwin wrote: > > Date: Tue Jul 14 20:46:19 2009 > > New Revision: 195696 > > URL: http://svn.freebsd.org/changeset/base/195696 > > Log: > > MFC: Use the closefrom(2) system call. > > Modified: > > stable/7/crypto/openssh/ (props changed) > > stable/7/crypto/openssh/config.h > > stable/7/crypto/openssh/ssh_namespace.h > > stable/7/secure/lib/libssh/ (props changed) > > stable/7/secure/lib/libssh/Makefile > > Hi John, > Would you mind backing out this commit from 7-stable. > This change mades it so one cannot seriously boot a machine multiuser > with an older kernel as /usr/sbin/sshd dies due to bad system call. I > think the MFC of this part of the closefrom(2) addtion edge up against > POLA for a mature -stable branch. > > Even in -CURRENT it's good form to add a new system call and then > immedately use it... without some time laps to allow folks to boot > a week old kernel. Will do, no problem. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907210933.24176.jhb>