Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 1 Nov 2025 10:22:37 -0700
From:      Adrian Chadd <adrian@freebsd.org>
To:        Mark Millard <marklmi@yahoo.com>
Cc:        bob prohaska <fbsd@www.zefox.net>, freebsd-arm@freebsd.org,  freebsd-current@freebsd.org
Subject:   Re: Buildkernel fails in /usr/obj/usr/src/arm.armv7/sys/GENERIC/vchiq_shim.o
Message-ID:  <CAJ-VmoktvOCA0s2Eww1p9Pziku%2BpFG6EkTx_H72Vq_Du%2BRPmLQ@mail.gmail.com>
In-Reply-To: <B97BAB7E-911B-4ECF-9956-93C2C9BD0AFE@yahoo.com>
References:  <aQYkxXD74zoukc0F@www.zefox.net> <CAJ-VmokLWxBfHM7TNE8jXx8kXTvYpdUnfE28VxFggFJkaD635A@mail.gmail.com> <B97BAB7E-911B-4ECF-9956-93C2C9BD0AFE@yahoo.com>
index | next in thread | previous in thread | raw e-mail 

[-- Attachment #1 --]
Here's my suggested solution:

===
diff --git a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c
b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c
index 96c3a0db8aa5..7e105a6b3b77 100644
--- a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c
+++ b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c
@@ -628,7 +628,9 @@ free_pagelist(BULKINFO_T *bi, int actual)
        pagelist = bi->pagelist;

        vchiq_log_trace(vchiq_arm_log_level,
-               "free_pagelist - %zx, %d (%u bytes @%p)", (size_t)pagelist,
actual, pagelist->length, bi->buf);
+           "free_pagelist - %zx, %d (%lu bytes @%p)",
+           (size_t)pagelist, (int)actual, (unsigned long)pagelist->length,
+           bi->buf);

        num_pages =
                (pagelist->length + pagelist->offset + PAGE_SIZE - 1) /
===

The code /is/ being compiled on my arm64 and armv7 builds, I verified this
by using #error in this source file. But the format strings aren't
eliciting a type violation when I cross compile.

[-- Attachment #2 --]
<div dir="ltr"><div>Here&#39;s my suggested solution:</div><div><br></div><div>===</div><div>diff --git a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c<br>index 96c3a0db8aa5..7e105a6b3b77 100644<br>--- a/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c<br>+++ b/sys/contrib/vchiq/interface/vchiq_arm/vchiq_2835_arm.c<br>@@ -628,7 +628,9 @@ free_pagelist(BULKINFO_T *bi, int actual)<br>        pagelist = bi-&gt;pagelist;<br> <br>        vchiq_log_trace(vchiq_arm_log_level,<br>-               &quot;free_pagelist - %zx, %d (%u bytes @%p)&quot;, (size_t)pagelist, actual, pagelist-&gt;length, bi-&gt;buf);<br>+           &quot;free_pagelist - %zx, %d (%lu bytes @%p)&quot;,<br>+           (size_t)pagelist, (int)actual, (unsigned long)pagelist-&gt;length,<br>+           bi-&gt;buf);<br> <br>        num_pages =<br>                (pagelist-&gt;length + pagelist-&gt;offset + PAGE_SIZE - 1) /<br>===</div><div><br></div><div>The code /is/ being compiled on my arm64 and armv7 builds, I verified this by using #error in this source file. But the format strings aren&#39;t eliciting a type violation when I cross compile.</div></div>
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmoktvOCA0s2Eww1p9Pziku%2BpFG6EkTx_H72Vq_Du%2BRPmLQ>