Date: Sat, 02 Jul 2005 00:45:47 -0400 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Vladimir Chukharev <chu@h33.erkki.ton.tut.fi> Cc: gnome@FreeBSD.org Subject: Re: HEADS UP: Realtime update support added to battstat Message-ID: <1120279547.45944.6.camel@shumai.marcuscom.com> In-Reply-To: <op.ss8688q1sh9hi4@localhost> References: <op.ss6v8jjc1taxl4@kempc17.me.tut.fi> <op.ss66x52ish9hi4@localhost> <1120162303.36495.6.camel@shumai.marcuscom.com> <op.ss8688q1sh9hi4@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-HLuPRLa5F8jtnscKOWql Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2005-07-02 at 00:28 +0300, Vladimir Chukharev wrote: > On Thu, 30 Jun 2005 23:11:43 +0300, Joe Marcus Clarke <marcus@FreeBSD.org= > wrote: >=20 > > I went through the code again, but I did not see any obvious file > > descriptor leaks. I did, however, find a few other bugs. I've posted = a > > new version of the battstat patch at > > http://www.marcuscom.com/downloads/patch-battstat-acpi. Please try thi= s > > new version, and if you see those maxfiles messages again, get the > > output of lsof for the battstat process (i.e. lsof -p <PID of > > battstat-applet-2>). >=20 > I put this patch instead of /usr/ports/x11/gnomeapplets2/files/patch-batt= stat-acpi > reinstalled the port and added the Battery Monitor to a panel. > then I ran lsof -p on it a few times. Each time the result was longer > and longer, the lines with /dev/acpi were multiplying... > I did not wait till I run out of maxfiles limit, just removed > the monitor. >=20 > Result of one of the lsof runs is attached. Ah! I was looking for a devd file descriptor leak. I completely forgot about /dev/acpi. The fact that you're running into this leak means you're probably not connecting to devd.pipe correctly. Check the perms on /var/run/devd.pipe to make sure they're 0666. However, I have fixed the leak, and a new patch is up at http://www.marcuscom.com/downloads/patch-battstat-acpi. Joe >=20 > --=20 > V.Chukharev --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-HLuPRLa5F8jtnscKOWql Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBCxhv7b2iPiv4Uz4cRAsDZAKCAA4110NHn0AP9Alkxq3EUdFC7SgCeJe98 A/jdSaxK36DKZtY3cMRCx2I= =IU5l -----END PGP SIGNATURE----- --=-HLuPRLa5F8jtnscKOWql--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1120279547.45944.6.camel>