Date: Thu, 14 Feb 2013 20:37:35 +1030 (CST) From: Jarrod Sayers <jarrod@downtools.com.au> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/176140: [patch] comms/minicom: Correct Previous NOPORTDOCS Logic Message-ID: <201302141007.r1EA7Z2o093923@mail.downtools.com.au> Resent-Message-ID: <201302141020.r1EAK1Vi096941@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 176140 >Category: ports >Synopsis: [patch] comms/minicom: Correct Previous NOPORTDOCS Logic >Confidential: no >Severity: non-critical >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Feb 14 10:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Jarrod Sayers >Release: FreeBSD 9.0-RELEASE-p5 i386 >Organization: >Environment: System: FreeBSD mail.downtools.com.au 9.0-RELEASE-p5 FreeBSD 9.0-RELEASE-p5 #23: Sat Dec 15 08:56:43 CST 2012 root@burbank.downtools.com.au:/usr/obj/usr/src/sys/BURBANK i386 >Description: The recent commit to comms/minicom r311786 appears to have slightly incorrect logic around the change from NOPORTDOCS to PORT_OPTIONS:MDOCS. If true, the former prevents port documentation from being installed however the latter allows the documentation to be installed. The condition on line 63 was not changed resulting in the evaluation being the inverse, i.e. port documentation being installed when explicitly told not to, and not being installed when told to. Attach patch drops the wayward ! symbol. >How-To-Repeat: >Fix: Patch can also be downloaded from: http://www.downtools.com.au/~jarrod/FreeBSD/comms-minicom-PORT_OPTIONS.diff --- comms-minicom-PORT_OPTIONS.diff begins here --- diff -ruN ports/comms/minicom.orig/Makefile ports/comms/minicom/Makefile --- ports/comms/minicom.orig/Makefile 2013-02-07 09:05:10.000000000 +1030 +++ ports/comms/minicom/Makefile 2013-02-14 20:05:58.000000000 +1030 @@ -60,7 +60,7 @@ ${CHMOD} 4511 ${PREFIX}/bin/minicom ${INSTALL} -d -o root -g wheel -m 0755 ${PREFIX}/etc/minicom ${CHOWN} uucp ${PREFIX}/etc/minicom -.if !${PORT_OPTIONS:MDOCS} +.if ${PORT_OPTIONS:MDOCS} ${INSTALL} -d -o root -g wheel -m 0755 ${DOCSDIR} ${INSTALL_DATA} ${WRKSRC}/AUTHORS ${DOCSDIR}/ ${INSTALL_DATA} ${WRKSRC}/COPYING ${DOCSDIR}/ --- comms-minicom-PORT_OPTIONS.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302141007.r1EA7Z2o093923>