Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Sep 2009 08:16:13 +0000 (UTC)
From:      Lawrence Stewart <lstewart@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r197451 - projects/tcp_ffcaia2008_8.x/sys/netinet
Message-ID:  <200909240816.n8O8GDrr089451@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: lstewart
Date: Thu Sep 24 08:16:12 2009
New Revision: 197451
URL: http://svn.freebsd.org/changeset/base/197451

Log:
  Enable the KASSERT to catch accounting errors now that the patch to add
  sack_hole_bytes has been tested and works well.
  
  Sponsored by:	FreeBSD Foundation

Modified:
  projects/tcp_ffcaia2008_8.x/sys/netinet/tcp_sack.c

Modified: projects/tcp_ffcaia2008_8.x/sys/netinet/tcp_sack.c
==============================================================================
--- projects/tcp_ffcaia2008_8.x/sys/netinet/tcp_sack.c	Thu Sep 24 07:11:23 2009	(r197450)
+++ projects/tcp_ffcaia2008_8.x/sys/netinet/tcp_sack.c	Thu Sep 24 08:16:12 2009	(r197451)
@@ -344,17 +344,12 @@ tcp_sackhole_remove(struct tcpcb *tp, st
 	/* Free this SACK hole. */
 	tcp_sackhole_free(tp, hole);
 
-	/*
 #ifdef INVARIANTS
 	if (TAILQ_EMPTY(&tp->snd_holes))
 		KASSERT(tp->sack_hole_bytes == 0,
-			("tp->sack_hole_bytes is %d instead of 0", tp->sack_hole_bytes));
+		    ("tp->sack_hole_bytes is %d instead of 0",
+		    tp->sack_hole_bytes));
 #endif
-	*/
-	if (TAILQ_EMPTY(&tp->snd_holes) && tp->sack_hole_bytes != 0) {
-		printf("conn (%p) tp->sack_hole_bytes is %d instead of 0\n", tp, tp->sack_hole_bytes);
-		tp->sack_hole_bytes = 0;
-	}
 }
 
 /*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200909240816.n8O8GDrr089451>