Date: Tue, 14 Oct 2008 21:27:44 +0100 From: Rui Paulo <rpaulo@FreeBSD.org> To: Stanislav Sedov <stas@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r183751 - user/rpaulo/eeemon Message-ID: <0D0B75E9-4C48-4A50-B34F-2CF1886A1839@FreeBSD.org> In-Reply-To: <20081014032137.13da1212.stas@FreeBSD.org> References: <200810101753.m9AHrQJU097333@svn.freebsd.org> <20081014032137.13da1212.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14 Oct 2008, at 00:21, Stanislav Sedov wrote: > On Fri, 10 Oct 2008 17:53:26 +0000 (UTC) > Rui Paulo <rpaulo@FreeBSD.org> mentioned: > >> Author: rpaulo >> Date: Fri Oct 10 17:53:26 2008 >> New Revision: 183751 >> URL: http://svn.freebsd.org/changeset/base/183751 >> >> Log: >> eeemon is a kernel module for Asus Eee notebooks that allows you to >> control the fan speed, high/low voltage and it shows the cpu >> temperature. >> >> Includes fan control code by "harrow@yandex.ru". >> Imported from my peronal repo. >> > >> + >> +static void >> +eeemon_identify(driver_t *driver, device_t parent) >> +{ >> + device_t child; >> + >> + if (device_find_child(parent, "eeemon", -1) != NULL) >> + return; >> + >> + if (eeemon_match() == 0) >> + return; >> + >> + child = BUS_ADD_CHILD(parent, ISA_ORDER_SPECULATIVE, "eeemon", -1); >> + if (child == NULL) >> + device_printf(parent, "add eeemon child failed\n"); >> + > > Do we need to attach to a 'real' bus here? Technically, no. But as Warner said, the isa bus is good as any. > Btw, should it really belong to the kernel code? As all operations are > performed via inb/out it's a clear fit for a userland program. Not necessarily, but this is what I've done, so I thought I would commit it. Regards, -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0D0B75E9-4C48-4A50-B34F-2CF1886A1839>