Date: Sun, 12 Sep 2010 17:03:44 +0000
From: Alexander Best <arundel@freebsd.org>
To: Marius Strobl <marius@alchemy.franken.de>
Cc: freebsd-current@freebsd.org
Subject: Re: {arch}/conf/DEFAULTS and uart
Message-ID: <20100912170344.GA58722@freebsd.org>
In-Reply-To: <20100912162352.GA89643@alchemy.franken.de>
References: <20100909191750.GA58228@freebsd.org> <20100909194109.GA64914@freebsd.org> <20100909195045.GA68352@freebsd.org> <201009100747.39964.jhb@freebsd.org> <20100912024049.GA32655@freebsd.org> <20100912162352.GA89643@alchemy.franken.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun Sep 12 10, Marius Strobl wrote: > On Sun, Sep 12, 2010 at 02:40:49AM +0000, Alexander Best wrote: > > On Fri Sep 10 10, John Baldwin wrote: > > > On Thursday, September 09, 2010 3:50:45 pm Alexander Best wrote: > > > > On Thu Sep 9 10, Alexander Best wrote: > > > > > On Thu Sep 9 10, Alexander Best wrote: > > > > > > hi there, > > > > > > > > > > > > except for arm most archs seem to enforce uart support in conf/DEFAULTS. is > > > > > > this really necessary? shouldn't DEFAULTS only contain vital devices/options > > > > > > without a kernel on a specific arch won't function at all? > > > > > > > > > > jhb just explained to me, that the uart entry in DEFAULTS is not a controller > > > > > or something like that, but the uart backend to use *if* uart gets defined in > > > > > the kernel config. > > > > > > > > > > sorry for the noise folks. > > > > > > > > however i found some missing comments and incorrect syntax which i fixed. > > > > > > > > see the attached patch. > > > > > > I think the ia64 ordering for 'io and mem' is probably more correct > > > (alphabetically sorted), so I would fix i386 and amd64 and leave ia64 alone. > > > > > > The powerpc 'machine' changes are wrong I think as it would break GENERIC64 > > > and powerpc64 kernel configs in general. Nathan purposefully removed > > > 'machine' from the powerpc DEFAULTS. > > > > here's try #2. ;) > > > > diff --git a/sys/sparc64/conf/DEFAULTS b/sys/sparc64/conf/DEFAULTS > > index 38b2408..2e60c94 100644 > > --- a/sys/sparc64/conf/DEFAULTS > > +++ b/sys/sparc64/conf/DEFAULTS > > @@ -5,7 +5,7 @@ > > > > machine sparc64 > > > > -# Pseudo devices. > > +# Pseudo devices > > device mem # Memory and kernel memory devices > > > > # UART chips on this platform > > @@ -17,5 +17,5 @@ device uart_z8530 > > options GEOM_PART_BSD > > options GEOM_PART_VTOC8 > > > > -# Let sunkbd emulate an AT keyboard by default. > > +# Let sunkbd emulate an AT keyboard by default > > IMO this is a complete sentence and thus the period should stay. agreed. :) also i think i accidently replaced the tab between the two words "powerpc" in sys/powerpc/conf/GENERIC with a space. :( also i noticed that after keywords like "device" there're two tabs, whereas after the keyword "options" there's one space and a tab. since i don't know, if this was done on purpose i didn't change it. cheers. alex > > Marius > -- a13x
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100912170344.GA58722>