Date: Tue, 13 Nov 2018 18:43:39 -0800 From: Conrad Meyer <cem@freebsd.org> To: Daniel Eischen <deischen@freebsd.org> Cc: freebsd-current <freebsd-current@freebsd.org>, Johannes Lundberg <johalun0@gmail.com> Subject: Re: No amdtemp sysctls, acpi errors, AMD Ryzen 5 2400G Message-ID: <CAG6CVpU9Hy9ih_kpPpFB9wRqFZD1G3M1JL06zGE_MUcCyGKdwg@mail.gmail.com> In-Reply-To: <CAG6CVpXuEVMJuLzgQv2JqJBTxd9rkez=2tNKOq%2B1%2B4KX5_Q-Rw@mail.gmail.com> References: <Pine.GSO.4.64.1811131259350.27287@sea.ntplx.net> <CAG6CVpXHKVWonG9bv1oqYD45LzK5dMvqnC70%2BoKSma%2Bi_9vR0A@mail.gmail.com> <Pine.GSO.4.64.1811132121560.29021@sea.ntplx.net> <CAG6CVpXuEVMJuLzgQv2JqJBTxd9rkez=2tNKOq%2B1%2B4KX5_Q-Rw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Of course, Johannes has already thought of this! See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228480 and https://reviews.freebsd.org/D15567 . On Tue, Nov 13, 2018 at 6:41 PM Conrad Meyer <cem@freebsd.org> wrote: > > On Tue, Nov 13, 2018 at 6:26 PM Daniel Eischen <deischen@freebsd.org> wrote: > > I've attached it. If it gets filtered by the mail list, I'll > > make it http accessible. > > Thanks Daniel. > > It looks like your hostbridge zero device has a different device id > than in my first generation Ryzen system. Would you please try the > following patch and see if it attaches on your system? I don't > actually have documentation for Ryzen 2, unfortunately, so I'm not > totally sure if the SMN is accessed in the same way for the new > hostbridge device id. The change below should at least attempt > attaching to hostb0 on your system. > > diff --git a/sys/dev/amdsmn/amdsmn.c b/sys/dev/amdsmn/amdsmn.c > index 17792dd922cd..6fe36b4cc4da 100644 > --- a/sys/dev/amdsmn/amdsmn.c > +++ b/sys/dev/amdsmn/amdsmn.c > @@ -60,7 +60,8 @@ struct amdsmn_softc { > static struct pciid { > uint32_t device_id; > } amdsmn_ids[] = { > - { 0x14501022 }, > + { 0x14501022 }, /* Ryzen */ > + { 0x15d01022 }, /* Ryzen 2 */ > }; > > /* > diff --git a/sys/dev/amdtemp/amdtemp.c b/sys/dev/amdtemp/amdtemp.c > index 2463212c25f5..765e660a8461 100644 > --- a/sys/dev/amdtemp/amdtemp.c > +++ b/sys/dev/amdtemp/amdtemp.c > @@ -102,6 +102,7 @@ static struct amdtemp_product { > { VENDORID_AMD, DEVICEID_AMD_MISC16_M30H }, > { VENDORID_AMD, DEVICEID_AMD_MISC17 }, > { VENDORID_AMD, DEVICEID_AMD_HOSTB17H }, > + { VENDORID_AMD, 0x15d0 }, > }; > > /* > > > Thanks, > Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpU9Hy9ih_kpPpFB9wRqFZD1G3M1JL06zGE_MUcCyGKdwg>