Date: Mon, 29 Mar 2004 23:06:43 -0800 From: Luigi Rizzo <rizzo@icir.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: current@freebsd.org Subject: Re: proposed bsdlabel patch Message-ID: <20040329230643.B70930@xorpc.icir.org> In-Reply-To: <20040330005013.GA53546@ns1.xcllnt.net>; from marcel@xcllnt.net on Mon, Mar 29, 2004 at 04:50:13PM -0800 References: <20040329163926.A38109@xorpc.icir.org> <20040330005013.GA53546@ns1.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 29, 2004 at 04:50:13PM -0800, Marcel Moolenaar wrote: > On Mon, Mar 29, 2004 at 04:39:26PM -0800, Luigi Rizzo wrote: > > if there are no strong objections, I'd like to commit > > the following minor patch to bsdlabel (and associated bsdlabel.8 > > changes) to implement a '-f' option which enables bsdlabel to > > work on an image file too. > > As Julian mentioned, why not use stat(2) and DTRT without options? > That also removes the gratuitous requirement that the filename has > to be an absolute path. See also the implementation of gpt(8)... sure, will do that, and take care of the style bugs as bruce suggested (the original patch was voluntarily formatted in a way to reduce the diffs). thanks for the feedback cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040329230643.B70930>