Date: Mon, 26 Nov 2012 11:57:37 -0500 From: Eitan Adler <eadler@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Guido Falsi <madpilot@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r307782 - head/audio/asunder Message-ID: <CAF6rxg=qHkUEPt9f7KG=jdiS0rgR80byM83GDjnYExa74u=dzA@mail.gmail.com> In-Reply-To: <20121126161113.GA72036@FreeBSD.org> References: <201211261259.qAQCxdXD089022@svn.freebsd.org> <20121126135609.GC62928@FreeBSD.org> <50B39163.2040309@FreeBSD.org> <20121126161113.GA72036@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26 November 2012 11:11, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Mon, Nov 26, 2012 at 04:57:23PM +0100, Guido Falsi wrote:
>> On 11/26/12 14:56, Alexey Dokuchaev wrote:
>> >We have standard knob for this one (APE_DESC).
>> >
>> >> PORTDOCS= AUTHORS COPYING ChangeLog INSTALL NEWS README TODO
>> >
>> >Normally we do not install COPYING as part of the docs, LICENSE should be
>> >set instead. If software expects to find this file (e.g. for displaying in
>> >the about dialog), it should be redirected to share/licenses/${PKGNAME}
>> >instead (see `graphics/luminance' port for an example).
>>
>> Thanks for these, I'll fix them and commit after maintainer approval.
>
> Technically speaking, you don't have to have maintainer's approval for these
> things, as they don't affect functionality, just make the port more adhering
> to our standards (and common sense).
It is good to ping the maintainer though unless there is specific reason not to.
- Since they signed up to maintain the port its nice not to change
things without asking
- It teaches the maintainers about our standards :)
--
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=qHkUEPt9f7KG=jdiS0rgR80byM83GDjnYExa74u=dzA>