Date: Fri, 27 May 2016 14:03:55 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Ivan Klymenko <fidaj@ukr.net>, Alan Cox <alc@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300865 - in head/sys: sys vm Message-ID: <016BEE0D-05B6-4042-8CD4-471D4D1C9162@gmail.com> In-Reply-To: <20160527210148.GR38613@kib.kiev.ua> References: <201605271915.u4RJFkEl013139@repo.freebsd.org> <20160527225103.67ae3547@nonamehost.local> <20160527210148.GR38613@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_C027044C-210E-43F8-95EC-18716830D6E9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 27, 2016, at 14:01, Konstantin Belousov <kostikbel@gmail.com> = wrote: >=20 > On Fri, May 27, 2016 at 10:51:03PM +0300, Ivan Klymenko wrote: >> On Fri, 27 May 2016 19:15:46 +0000 (UTC) >> Alan Cox <alc@FreeBSD.org> wrote: >>=20 >>> Author: alc >>> Date: Fri May 27 19:15:45 2016 >>> New Revision: 300865 >>> URL: https://svnweb.freebsd.org/changeset/base/300865 >>>=20 >>> Log: >>> The flag "vm_pages_needed" has long served two distinct purposes: >>> (1) to indicate that threads are waiting for free pages to become >>> available and (2) to indicate whether a wakeup call has been sent to >>> the page daemon. The trouble is that a single flag cannot really >>> serve both purposes, because we have two distinct targets for when = to >>> wakeup threads waiting for free pages versus when the page daemon = has >>> completed its work. In particular, the flag will be cleared by >>> vm_page_free() before the page daemon has met its target, and this >>> can lead to the OOM killer being invoked prematurely. To address = this >>> problem, a new flag "vm_pageout_wanted" is introduced. >>> Discussed with: jeff >>> Reviewed by: kib, markj >>> Tested by: markj >>> Sponsored by: EMC / Isilon Storage Division >>>=20 >>> Modified: >>> head/sys/sys/vmmeter.h >>> head/sys/vm/vm_page.c >>> head/sys/vm/vm_pageout.c >>> head/sys/vm/vm_pageout.h >>>=20 >>> Modified: head/sys/vm/vm_pageout.h >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/vm/vm_pageout.h Fri May 27 18:52:58 2016 >>> (r300864) +++ head/sys/vm/vm_pageout.h Fri May 27 19:15:45 >>> 2016 (r300865) @@ -72,9 +72,10 @@ >>> */ >>>=20 >>> extern int vm_page_max_wired; >>> -extern int vm_pages_needed; /* should be some "event" >>> structure */ extern int vm_pageout_deficit; >>> extern int vm_pageout_page_count; >>> +extern bool vm_pageout_wanted; >>> +extern bool vm_pages_needed; >>>=20 >>> /* >>> * Swap out requests >>> _______________________________________________ >>> svn-src-all@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/svn-src-all >>> To unsubscribe, send any mail to = "svn-src-all-unsubscribe@freebsd.org" >>=20 >> ... >> =3D=3D=3D> lib/libalias/modules/smedia (obj) >> --- cddl/lib__L --- >> In file included >> from = /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/commo= n/fs/zfs/arc.c:143: = /media/da0s1/obj/usr/src/tmp/usr/include/vm/vm_pageout.h:77:8: >> error: unknown type name 'bool' extern bool vm_pageout_wanted; >> ^ >> /media/da0s1/obj/usr/src/tmp/usr/include/vm/vm_pageout.h:78:8: error: >> unknown type name 'bool' extern bool vm_pages_needed; >> ^ >> 2 errors generated. >> *** [arc.So] Error code 1 >=20 > Does it compile if you just remove the > #include <vm/vm_pageout.h> > line from arc.c and possibly zfs_vnops.c ? >=20 > If not, try bracing the line with #ifdef _KERNEL, like this: I added #include <sys/types.h> to zfs/arc.c in r300870 =E2=80=94 = it was missing from the file. Looking into drm2 and ofed. Thanks! -Ngie --Apple-Mail=_C027044C-210E-43F8-95EC-18716830D6E9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXSLY8AAoJEPWDqSZpMIYVLC4P/2BJ9KFF+KHth97N1B3vX0Xg npqG2XTWAHvruQuvafuI/o5uo70i1p9ztV+gmN69JfMOwjraMdCWhQqGsGIiUdmG CHtxOKnsLWjDvw23y7wQU7nVBXAou3fcg1nmpaZ30bjXlZyoi7/6/LfPWGST2/VY pSxmpNSvOJaDnvDGjyHPUKTYqqHNruKQV5cjhytUqn/JWrAlwJ9KmZmj7blBE2aM /TTH/lAtHkTP6rnTVjAGS36DOoZ1eg/wanLuR6PnLggBYoThOvhxpGZ+aIGlJLzX zsSKK2FQRRFIwmR8LEiC7Z7tFgx6wAoZXMrePAeuuczH/vgmMjq1i3yYHFAbur1Z rCw8oKpS1YepBNjqK+bvD/ZiroSq4t6SQK3x2MS4dz0RzaMTYnGUS3h8uZk0Vk7I WqAX+A156uuB7ZGJyPtco5xFuYxIQZX70NPVzP9IduY169t4jyQjLRYcw7gf16V5 aRWH9MB5jF+zCB4dsyyuXYsNNKUreSWTZyX3DrDYmfN4WSrGUObibMcC9kxbuy0b MZ+8QvM6TnPhwBabCUhS5+Du18Q8C2VkEF5CWKYz4ERWrTsfqTrPEAPbvWkVhrd5 FKELfFuGaJoK6P+ug4q6tyTtNFnFAi3cX6GxBXsfy0BuekFYkmg3f3b1MvHzaFli Eb9kcpf6jMGW8x/6Uzi8 =15f2 -----END PGP SIGNATURE----- --Apple-Mail=_C027044C-210E-43F8-95EC-18716830D6E9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?016BEE0D-05B6-4042-8CD4-471D4D1C9162>