Date: Mon, 12 Dec 2022 00:37:55 +0100 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Yuri Victorovich <yuri@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d5a8c7ca5954 - main - cad/nvc: Correction of the conditional statement Message-ID: <Y5Zp0w/1xW1TpgQq@KGPE-D16> In-Reply-To: <202212111922.2BBJMN98026340@gitrepo.freebsd.org> References: <202212111922.2BBJMN98026340@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--wSdMhO1JqLuM2wOO
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
So, now it ended up with:
.include <bsd.port.options.mk>
.if ${ARCH} == "i386" # see the bug#268319 for the LTO failure on i386
CONFIGURE_ARGS+= --disable-lto # workaround for https://github.com/nickg/nvc/issues/579 (undefined symbol: _GLOBAL_OFFSET_TABLE_, see error: undefined symbol: _GLOBAL_OFFSET_TABLE_)
.endif
${OTHER_STUFF}
.include <bsd.port.options.mk>
.if ${ARCH} == powerpc64
CONFIGURE_ARGS+= --enable-lto=no
.endif
Why not use one conditional for both i386 and powerpc64?
Does double inclusion of bsd.port.options.mk even work correctly?
On 22-12-11 19:22:23, Yuri Victorovich wrote:
>The branch main has been updated by yuri:
>
>URL: https://cgit.FreeBSD.org/ports/commit/?id=d5a8c7ca5954840b99c01aff42630441b90ae237
>
>commit d5a8c7ca5954840b99c01aff42630441b90ae237
>Author: Yuri Victorovich <yuri@FreeBSD.org>
>AuthorDate: 2022-12-11 19:21:56 +0000
>Commit: Yuri Victorovich <yuri@FreeBSD.org>
>CommitDate: 2022-12-11 19:21:56 +0000
>
> cad/nvc: Correction of the conditional statement
>---
> cad/nvc/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/cad/nvc/Makefile b/cad/nvc/Makefile
>index 4b8e9d10d601..9404d23dc65b 100644
>--- a/cad/nvc/Makefile
>+++ b/cad/nvc/Makefile
>@@ -34,6 +34,8 @@ GNU_CONFIGURE= yes
> LDFLAGS+= -lexecinfo
>
> CONFIGURE_ARGS= --with-llvm=${LOCALBASE}/bin/llvm-config${LLVM_VERSION}
>+
>+.include <bsd.port.options.mk>
> .if ${ARCH} == "i386" # see the bug#268319 for the LTO failure on i386
> CONFIGURE_ARGS+= --disable-lto # workaround for https://github.com/nickg/nvc/issues/579 (undefined symbol: _GLOBAL_OFFSET_TABLE_, see error: undefined symbol: _GLOBAL_OFFSET_TABLE_)
> .endif
--wSdMhO1JqLuM2wOO
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmOWadMwFIAAAAAAFQAS
cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug
g5ydkIwP/AnaB+gxiNrUYr2g+DzUm78owqkBWi+UZUYomkXDo0m2wzXpWyXqkM7u
M5v6FjN2qK6QtqWiXXQ5sVXKcf1ZvUKuYxT7rOKolIGKuQQGz4RwTP+LHuzcC/oh
hY2OiJFnJkqQj3YqdY4+eWp/Hib7DDLli+e/Lwlj1UEnyc6E/6qRGJx8tLlXlsQj
uvvGjPjvDfrg30UUu7EUpFzbPp5SB4KIPjLemqGeExL4O8pAo3PFZNWeK1fg/35M
MZoGXmteMgp3fBy0AGrB54voDkKy6hhUPxqmMPOF3fueB0mX5OzEsZLSYp8ThTX3
7uU9gEv7dpjNfqKwXTjG6picee8+RR9ZAtEQf5y9s+PzTesfW1EPBbj7R45wIpp5
P+PXmFNVIv+Ew/iVrtJoIU6W3I09+p25k3fMb4jaktYV7i5+Jh6C40/Hujsm1/PP
MXQFQEu129cBJ4/+s0ARR++SV98mpQTwJVtdNquXnZtwmZ+1TQiGVTxTDgIAIjLX
fwEAucTKxrFIrtN88rZTWx1oJMJsl1/+sdH7U3vWsQmMS+rNwEKefMDfY+aqHt3Q
T6GR7NITOI/RuSppuRcZ+MBljErw3kCB5YBr2BD2HY+ZR/jRCKVQ2wsVEa2Dr9EQ
3OY2Yyhh6Wt5PC3o0mg15VB3l/V0M5ac9afNBRwfTcY2lCRGgb+c
=VTXv
-----END PGP SIGNATURE-----
--wSdMhO1JqLuM2wOO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Y5Zp0w/1xW1TpgQq>