Date: Wed, 26 Aug 2020 19:42:50 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Dimitry Andric <dim@FreeBSD.org> Cc: Ian Lepore <ian@FreeBSD.org>, Mateusz Guzik <mjguzik@gmail.com>, Jung-uk Kim <jkim@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364822 - in head/crypto/openssl/crypto: aes/asm bn/asm chacha/asm ec/asm modes/asm poly1305/asm sha/asm Message-ID: <187C5112-6E19-4155-9226-FD23BA03ABA9@freebsd.org> In-Reply-To: <0FAD8A61-49D2-4419-8744-1BAE6DA9C6C2@FreeBSD.org> References: <202008261655.07QGtSZx096979@repo.freebsd.org> <CAGudoHGfUpzbmjmd1Q=pG7LyOM3uCKEhq%2BiF6-X_p_SLKbyfVA@mail.gmail.com> <7f1149b6e8dfd1600ff235b7b1aaae3b746b4a9f.camel@freebsd.org> <0FAD8A61-49D2-4419-8744-1BAE6DA9C6C2@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26 Aug 2020, at 19:33, Dimitry Andric <dim@FreeBSD.org> wrote: > > On 26 Aug 2020, at 19:13, Ian Lepore <ian@FreeBSD.org> wrote: >> >> On Wed, 2020-08-26 at 19:04 +0200, Mateusz Guzik wrote: >>> On 8/26/20, Jung-uk Kim <jkim@freebsd.org> wrote: >>>> Author: jkim >>>> Date: Wed Aug 26 16:55:28 2020 >>>> New Revision: 364822 >>>> URL: https://svnweb.freebsd.org/changeset/base/364822 >>>> >>>> Log: >>>> Fix Clang version detection. >>>> >>>> We prepend "FreeBSD" to Clang version string. This broke >>>> compiler test >>>> for >>>> AVX instruction support. >>>> >>> >>> What about other software checking in similar fashion? imo the right >>> fix is to stop mucking with the way clang reports itself >>> >> >> Maybe it would be better to not modify the start of the string. >> Instead of >> >> FreeBSD clang version 9.0.1 (git@github.com:llvm/llvm-project.git >> c1a0a213378a458fbea1a5c77b315c7dce08fd05) (based on LLVM 9.0.1) >> >> maybe >> >> clang version 9.0.1 for FreeBSD (git@github.com:llvm/llvm-project.git >> c1a0a213378a458fbea1a5c77b315c7dce08fd05) (based on LLVM 9.0.1) > > We have been doing this since, well, forever. And this way actually > originates from upstream, we only define the CLANG_VENDOR macro. I see > no reason to change this after all those years. > > A better question is, why these perl scripts "suddenly" started failing? > Or have they also failed since forever, and it was only noticed now? Ah, digging deeper it gets more interesting. All those scripts check for "based on LLVM X.Y", a suffix printed for vendor builds. However, that was dropped in https://reviews.llvm.org/D69925 as it's redundant, thereby breaking this detection. So it's fallout from LLVM 10. Also the scripts aren't failing in a sense, they just don't know what compiler is in use so they fall back on not enabling AVX. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?187C5112-6E19-4155-9226-FD23BA03ABA9>