Date: Tue, 13 Oct 2009 22:05:18 +0200 From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <eri@freebsd.org> To: Julian Elischer <julian@elischer.org> Cc: Max Laier <max@love2party.net>, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org>, svn-src-user@freebsd.org Subject: Re: svn commit: r198007 - user/eri/pf45/head/sys/contrib/pf/net Message-ID: <9a542da30910131305o2f247f62oa8c38ce908456568@mail.gmail.com> In-Reply-To: <4AD4DB68.2060202@elischer.org> References: <200910122226.n9CMQAYr087381@svn.freebsd.org> <200910130756.32986.jhb@freebsd.org> <4AD4DB68.2060202@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 13, 2009 at 9:56 PM, Julian Elischer <julian@elischer.org> wrot= e: > John Baldwin wrote: >> >> On Monday 12 October 2009 6:26:10 pm Ermal LuXi wrote: >>> >>> Author: eri >>> Date: Mon Oct 12 22:26:10 2009 >>> New Revision: 198007 >>> URL: http://svn.freebsd.org/changeset/base/198007 >>> >>> Log: >>> =A0* Prefix some other variables with V_ since their name is the same a= s >> >> their struct type. >>> >>> =A0* For being virtualization ready only contexes should be considered >> >> especially in event handlers. >> >> FWIW, I think it will be simpler to just have all virtualized variables >> start with V_ rather than having a partial mix. =A0They should either al= l have >> V_ or none of them have V_ as anything else will just be confusing. =A0A= nd >> since the case of none of them having V_ doesn't compile that narrows it >> down. :) >> > > Ermal, have you asked the OpenBSD guys if they'd accept any changes from = us > that would make it easier? > > > The SCTP guys agreed to put "SCTP_GLOBAL(name)" around their globals > with the comment that it would help them in their user-land version. > I do know that OpenBSD agreeing to do something purely for someone > else would be a rather drastic departure from their normal M.O. but > you won't know until you ask. > To my knowledge Max Laier(cc'd) is the better person to ask for this! Since his previous relation with pf(4) and OpenBSD guys. Max? --=20 Ermal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9a542da30910131305o2f247f62oa8c38ce908456568>