Date: Sun, 21 May 2017 20:34:31 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r318594 - in head: lib lib/libc++experimental tools/build/mk Message-ID: <55649C56-DA8E-41C5-91B4-E72FB6A07CBC@FreeBSD.org> In-Reply-To: <20170521180042.GK1622@kib.kiev.ua> References: <201705211707.v4LH7CbN016259@repo.freebsd.org> <20170521180042.GK1622@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 21 May 2017, at 20:00, Konstantin Belousov <kostikbel@gmail.com> wrote: > > On Sun, May 21, 2017 at 05:07:12PM +0000, Dimitry Andric wrote: >> Author: dim >> Date: Sun May 21 17:07:12 2017 >> New Revision: 318594 >> URL: https://svnweb.freebsd.org/changeset/base/318594 >> >> Log: >> Add libc++experimental.a for std::experimental support >> >> This adds a separate library for supporting std::experimental features. >> It is purposefully static, and must be explicitly linked into programs >> using -lc++experimental. >> >> PLEASE NOTE: there is NO WARRANTY as to any stability or continuing >> existence of the features in the std::experimental parts of the C++ >> library! >> >> Reviewed by: ed >> Differential Revision: https://reviews.freebsd.org/D10840 >> >> Added: >> head/lib/libc++experimental/ >> head/lib/libc++experimental/Makefile (contents, props changed) >> Modified: >> head/lib/Makefile >> head/tools/build/mk/OptionalObsoleteFiles.inc >> >> Modified: head/lib/Makefile >> ============================================================================== >> --- head/lib/Makefile Sun May 21 15:37:08 2017 (r318593) >> +++ head/lib/Makefile Sun May 21 17:07:12 2017 (r318594) >> @@ -156,7 +156,7 @@ _libclang_rt= libclang_rt >> >> .if ${MK_LIBCPLUSPLUS} != "no" >> _libcxxrt= libcxxrt >> -_libcplusplus= libc++ >> +_libcplusplus= libc++ libc++experimental >> .endif >> >> SUBDIR.${MK_EFI}+= libefivar >> >> Added: head/lib/libc++experimental/Makefile >> ============================================================================== >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ head/lib/libc++experimental/Makefile Sun May 21 17:07:12 2017 (r318594) >> @@ -0,0 +1,29 @@ >> +# $FreeBSD$ >> + >> +.include <src.opts.mk> >> + >> +PACKAGE= clibs >> +SRCDIR= ${SRCTOP}/contrib/libc++ >> + >> +LIB= c++experimental >> +NO_PIC= > I suspect for this case it is almost required to provide > libc++experimental_pic.a, otherwise linking the lib to dso would > cause textrel. Hmm, I don't know how to tell the build system otherwise that I don't want any shared library. It looks like NO_PIC is needed in bsd.lib.mk to force no .so to be built, though. Maybe it is easier to just build the .a file with -fPIC always? There is really no need for two .a files. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlkh3cEACgkQsF6jCi4glqO19gCbBa7FodF+0tf/Kx2IAm2XWEEX hhoAn0li8bAoxt9nWmRLQN55pSGISXd4 =JCBu -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55649C56-DA8E-41C5-91B4-E72FB6A07CBC>