Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Nov 2013 05:19:13 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Mark Felder <feld@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r332417 - head/deskutils/tine20
Message-ID:  <20131106051912.GA49604@FreeBSD.org>
In-Reply-To: <201311012241.rA1Mf9jY087068@svn.freebsd.org>
References:  <201311012241.rA1Mf9jY087068@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 01, 2013 at 10:41:09PM +0000, Mark Felder wrote:
> New Revision: 332417
> URL: http://svnweb.freebsd.org/changeset/ports/332417
> 
>  do-install:
> -	${MKDIR} ${WWWDIR}
> -	@cd ${WRKSRC} && ${COPYTREE_SHARE} \* ${WWWDIR}
> +	${MKDIR} ${STAGEDIR}${WWWDIR}
> +	@cd ${WRKSRC} && ${COPYTREE_SHARE} \* ${STAGEDIR}${WWWDIR}

It is better to use dot (.) rather than shell globs (no need to worry
about escaping, looks more neat, etc.).  Dot is also recommented syntax
per PH (section 5.15.3).

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131106051912.GA49604>