Date: Mon, 20 Aug 2012 22:44:27 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, "David E. O'Brien" <obrien@freebsd.org> Subject: Re: svn commit: r238563 - head/gnu/usr.bin/groff/tmac Message-ID: <20120821054427.4486F58085@chaos.jnpr.net> In-Reply-To: <201207301119.49002.jhb@freebsd.org> References: <201207180557.q6I5vheM034018@svn.freebsd.org> <201207301119.49002.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 30 Jul 2012 11:19:48 -0400, John Baldwin writes:
>> @@ -68,7 +68,7 @@ beforeinstall:
>> cd ${.CURDIR}; \
>> ${INSTALL} -o ${TMACOWN} -g ${TMACGRP} -m ${TMACMODE} \
>> koi8-r.tmac hyphen.ru ${DESTDIR}${TMACDIR}
>> - cd ${.OBJDIR}
>> + cd ${.OBJDIR};
>
>Isn't this a nop now? That is, it changes the working directory in a temporar
>y
>shell that immediately exits?
If a shell is used, yes.
Even in compat mode, bmake attempts to avoid the shell, so absent a clue
(like ';') it attempts - and fails direct exection.
A cd like that by itself generally makes no sense (as everyone has noted
;-)
The ';' was a minimal change to ensure consistent behavior b/w the two
makes, but re-working the target to avoid the need for that cd would be
better - as noted just now in response to Ruslan.
Thanks
--sjg
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120821054427.4486F58085>