Date: Mon, 22 Jan 2001 16:25:39 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Dag-Erling Smorgrav <des@ofug.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Luigi Rizzo <luigi@FreeBSD.org> Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c Message-ID: <XFMail.010122162539.jhb@FreeBSD.org> In-Reply-To: <xzpae8jgm66.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23-Jan-01 Dag-Erling Smorgrav wrote:
> Luigi Rizzo <luigi@FreeBSD.org> writes:
>> Log:
>> Change critical section protection for dummynet from splnet() to
>> splimp() -- we need it because dummynet can be invoked by the
>> bridging code at splimp().
>
> This has the net effect of replacing one no-op with another:
>
> root@des ~# egrep 'spl(imp|net)' /sys/sys/systm.h
> static __inline intrmask_t splimp(void) { return 0; }
> static __inline intrmask_t splnet(void) { return 0; }
>
> DES
It does apply to -stable however, and since this code is not MP safe, it will
help to ensure that when it is converted away from mutexes, the coders in
question will be aware of what types of things they may need to protect.
--
John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010122162539.jhb>