Date: Thu, 17 Jun 2010 18:30:56 -0400 From: Randall Stewart <rrs@lakerest.net> To: "M. Warner Losh" <imp@bsdimp.com> Cc: Alan Cox <alc@cs.rice.edu>, freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD - part 2 Message-ID: <763BEBBB-B85A-44CE-BFEE-0BADEFF3C185@lakerest.net> In-Reply-To: <20100617.110504.200754750200158040.imp@bsdimp.com> References: <20100617.100235.195066307596264499.imp@bsdimp.com> <AANLkTimkF47RlysFOrma0YhWNDw2w5Lcp9SB1bBoPuxW@mail.gmail.com> <4B66E1A4-E2A5-471F-9FA4-38B506797272@lakerest.net> <20100617.110504.200754750200158040.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 17, 2010, at 1:05 PM, M. Warner Losh wrote: > > > It was also a name-space collision, so we were using PG_x instead of > PG_y in the PTE code due to the overlap. Maybe it all works now, but > that was the motivation for the change. Yes, basically if I remember right someone used PG_GLOBAL instead of PG_G. This caused the wrong bits to be set. In general I think its a BAD idea to have two name spaces in the same section of the system (VM) that have similar define's that mean different things. Far better to KEEP the PTE_xxx or for that matter pick something else.. Just NOT PG_xxx R ------------------------------ Randall Stewart 803-317-4952 (cell)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?763BEBBB-B85A-44CE-BFEE-0BADEFF3C185>