Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 4 May 2024 15:38:39 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Lexi Winter <lexi@le-fay.org>
Cc:        Kelly Hays <j.kelly.hays@gmail.com>, Warner Losh <imp@freebsd.org>, src-committers@freebsd.org,  dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: cb808de400c7 - main - rc.conf.5: modernise network_interfaces
Message-ID:  <CANCZdforyLeBj_mCDkYMj9Tikb-fJdtA0GCPO_9jRqhGTtmsog@mail.gmail.com>
In-Reply-To: <ZjaPHb7bm22TmOPS@ilythia.eden.le-fay.org>
References:  <202405041645.444Gjn2b099621@gitrepo.freebsd.org> <CA%2BSWn32AWaov2TMvBDPEupdoymG3byxokk6ijoef79-y91DEcw@mail.gmail.com> <ZjaPHb7bm22TmOPS@ilythia.eden.le-fay.org>
next in thread | previous in thread | raw e-mail | index | archive | help 

[-- Attachment #1 --]
On Sat, May 4, 2024 at 1:40 PM Lexi Winter <lexi@le-fay.org> wrote:

> Kelly Hays:
> > On Sat, May 4, 2024 at 11:45 AM Warner Losh <imp@freebsd.org> wrote:
> > > @@ -2045,9 +2062,9 @@ interfaces with:
> > >  .Bd -literal
> > >  gif_interfaces="gif0 gif1"
> > >  gifconfig_gif0="100.64.0.1 100.64.0.2"
> > > -ifconfig_gif0="inet 10.0.0.1 10.0.0.2 netmask 255.255.255.252"
> > > +ifconfig_gif0="inet 10.0.0.1/32 10.0.0.2"
> > >  gifconfig_gif1="inet6 2a00::1 2a01::1"
> > > -ifconfig_gif1="inet 10.1.0.1 10.1.0.2 netmask 255.255.255.252"
> > > +ifconfig_gif1="inet 10.1.0.1/32 10.1.0.2"
> >
> > In the last example above the CIDR notation for the netmask of
> > 255.255.255.252 would be /30 not /32.
>
> yes, this is wrong.  imp: can you fix this or do you want a new PR?
>

I'll just commit a fix and give Kelly credit.

Warner

[-- Attachment #2 --]
<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, May 4, 2024 at 1:40 PM Lexi Winter &lt;<a href="mailto:lexi@le-fay.org">lexi@le-fay.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Kelly Hays:<br>
&gt; On Sat, May 4, 2024 at 11:45 AM Warner Losh &lt;<a href="mailto:imp@freebsd.org" target="_blank">imp@freebsd.org</a>&gt; wrote:<br>
&gt; &gt; @@ -2045,9 +2062,9 @@ interfaces with:<br>
&gt; &gt;  .Bd -literal<br>
&gt; &gt;  gif_interfaces=&quot;gif0 gif1&quot;<br>
&gt; &gt;  gifconfig_gif0=&quot;100.64.0.1 100.64.0.2&quot;<br>
&gt; &gt; -ifconfig_gif0=&quot;inet 10.0.0.1 10.0.0.2 netmask 255.255.255.252&quot;<br>
&gt; &gt; +ifconfig_gif0=&quot;inet <a href="http://10.0.0.1/32" rel="noreferrer" target="_blank">10.0.0.1/32</a> 10.0.0.2&quot;<br>
&gt; &gt;  gifconfig_gif1=&quot;inet6 2a00::1 2a01::1&quot;<br>
&gt; &gt; -ifconfig_gif1=&quot;inet 10.1.0.1 10.1.0.2 netmask 255.255.255.252&quot;<br>
&gt; &gt; +ifconfig_gif1=&quot;inet <a href="http://10.1.0.1/32" rel="noreferrer" target="_blank">10.1.0.1/32</a> 10.1.0.2&quot;<br>
&gt; <br>
&gt; In the last example above the CIDR notation for the netmask of<br>
&gt; 255.255.255.252 would be /30 not /32.<br>
<br>
yes, this is wrong.  imp: can you fix this or do you want a new PR?<br></blockquote><div><br></div><div>I&#39;ll just commit a fix and give Kelly credit.</div><div><br></div><div>Warner </div></div></div>

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdforyLeBj_mCDkYMj9Tikb-fJdtA0GCPO_9jRqhGTtmsog>