Date: Sat, 4 May 2024 15:38:39 -0600 From: Warner Losh <imp@bsdimp.com> To: Lexi Winter <lexi@le-fay.org> Cc: Kelly Hays <j.kelly.hays@gmail.com>, Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: cb808de400c7 - main - rc.conf.5: modernise network_interfaces Message-ID: <CANCZdforyLeBj_mCDkYMj9Tikb-fJdtA0GCPO_9jRqhGTtmsog@mail.gmail.com> In-Reply-To: <ZjaPHb7bm22TmOPS@ilythia.eden.le-fay.org> References: <202405041645.444Gjn2b099621@gitrepo.freebsd.org> <CA%2BSWn32AWaov2TMvBDPEupdoymG3byxokk6ijoef79-y91DEcw@mail.gmail.com> <ZjaPHb7bm22TmOPS@ilythia.eden.le-fay.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000083c2b40617a7a9f7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, May 4, 2024 at 1:40=E2=80=AFPM Lexi Winter <lexi@le-fay.org> wrote: > Kelly Hays: > > On Sat, May 4, 2024 at 11:45=E2=80=AFAM Warner Losh <imp@freebsd.org> w= rote: > > > @@ -2045,9 +2062,9 @@ interfaces with: > > > .Bd -literal > > > gif_interfaces=3D"gif0 gif1" > > > gifconfig_gif0=3D"100.64.0.1 100.64.0.2" > > > -ifconfig_gif0=3D"inet 10.0.0.1 10.0.0.2 netmask 255.255.255.252" > > > +ifconfig_gif0=3D"inet 10.0.0.1/32 10.0.0.2" > > > gifconfig_gif1=3D"inet6 2a00::1 2a01::1" > > > -ifconfig_gif1=3D"inet 10.1.0.1 10.1.0.2 netmask 255.255.255.252" > > > +ifconfig_gif1=3D"inet 10.1.0.1/32 10.1.0.2" > > > > In the last example above the CIDR notation for the netmask of > > 255.255.255.252 would be /30 not /32. > > yes, this is wrong. imp: can you fix this or do you want a new PR? > I'll just commit a fix and give Kelly credit. Warner --00000000000083c2b40617a7a9f7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Sat, May 4, 2024 at 1:40=E2=80=AFP= M Lexi Winter <<a href=3D"mailto:lexi@le-fay.org">lexi@le-fay.org</a>>= ; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px= 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Kelly H= ays:<br> > On Sat, May 4, 2024 at 11:45=E2=80=AFAM Warner Losh <<a href=3D"mai= lto:imp@freebsd.org" target=3D"_blank">imp@freebsd.org</a>> wrote:<br> > > @@ -2045,9 +2062,9 @@ interfaces with:<br> > >=C2=A0 .Bd -literal<br> > >=C2=A0 gif_interfaces=3D"gif0 gif1"<br> > >=C2=A0 gifconfig_gif0=3D"100.64.0.1 100.64.0.2"<br> > > -ifconfig_gif0=3D"inet 10.0.0.1 10.0.0.2 netmask 255.255.255= .252"<br> > > +ifconfig_gif0=3D"inet <a href=3D"http://10.0.0.1/32" rel=3D= "noreferrer" target=3D"_blank">10.0.0.1/32</a> 10.0.0.2"<br> > >=C2=A0 gifconfig_gif1=3D"inet6 2a00::1 2a01::1"<br> > > -ifconfig_gif1=3D"inet 10.1.0.1 10.1.0.2 netmask 255.255.255= .252"<br> > > +ifconfig_gif1=3D"inet <a href=3D"http://10.1.0.1/32" rel=3D= "noreferrer" target=3D"_blank">10.1.0.1/32</a> 10.1.0.2"<br> > <br> > In the last example above the CIDR notation for the netmask of<br> > 255.255.255.252 would be /30 not /32.<br> <br> yes, this is wrong.=C2=A0 imp: can you fix this or do you want a new PR?<br= ></blockquote><div><br></div><div>I'll just commit a fix and give Kelly= credit.</div><div><br></div><div>Warner=C2=A0</div></div></div> --00000000000083c2b40617a7a9f7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdforyLeBj_mCDkYMj9Tikb-fJdtA0GCPO_9jRqhGTtmsog>