Date: Sat, 16 Jun 2007 22:22:32 +0200 From: Wilko Bulte <wb@freebie.xs4all.nl> To: Erwin Lansing <erwin@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Scott Long <scottl@samsco.org>, src-committers@FreeBSD.org, Wilko Bulte <wilko@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ukbd.c Message-ID: <20070616202232.GA39158@freebie.xs4all.nl> In-Reply-To: <20070616201414.GM90672@droso.net> References: <200706161920.l5GJK2mk091919@repoman.freebsd.org> <46743999.3090505@samsco.org> <20070616200116.GA39011@freebie.xs4all.nl> <20070616201414.GM90672@droso.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 16, 2007 at 10:14:14PM +0200, Erwin Lansing wrote.. > On Sat, Jun 16, 2007 at 10:01:17PM +0200, Wilko Bulte wrote: > > On Sat, Jun 16, 2007 at 01:27:21PM -0600, Scott Long wrote.. > > > Wilko Bulte wrote: > > > > wilko 2007-06-16 19:20:02 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/dev/usb ukbd.c > > > > Log: > > > > Per request (to core) by the person refered to in the comment. > > > > > > > > Revision Changes Path > > > > 1.65 +0 -2 src/sys/dev/usb/ukbd.c > > > > > > This commit message makes no sense. > > > > I removed the 2 lines with the guys name/email address. > > > Which wasn't clear from the commit message. One needs to look up the > diff to find out *what* has happened while the commit message only > contains *why* it happened. The commit message should include both. > > "Remove comment per request (to core) from the person mentioned in it" Yeah yeah... I do make mistakes too, ok? -- Wilko Bulte wilko@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070616202232.GA39158>