Date: Fri, 12 Feb 2016 11:27:16 +0000 From: Steven Hartland <steven.hartland@multiplay.co.uk> To: Sean Bruno <sbruno@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r295525 - stable/10/sys/dev/ixgbe Message-ID: <56BDC194.6070001@multiplay.co.uk> In-Reply-To: <201602111635.u1BGZGTs031940@repo.freebsd.org> References: <201602111635.u1BGZGTs031940@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
There's a typo here and the unreverted version is still present in head,
was this the intention?
Clearly the code does limit it to 8, so the old description is more
correct, just needs the typo fixing, but I would have expected this to
have been corrected in head first and then MFC'ed
This was reported to me by Dmitry Luhtionov.
Regards
Steve
On 11/02/2016 16:35, Sean Bruno wrote:
> Author: sbruno
> Date: Thu Feb 11 16:35:16 2016
> New Revision: 295525
> URL: https://svnweb.freebsd.org/changeset/base/295525
>
> Log:
> Revert sysctl description change introduced in r295008 to correctly
> reflect the maximum number of queues supported (8) by this driver.
>
> Submitted by: jwd
> Reviewed by: erj
> Approved by: re (gjb)
> Sponsored by: Intel Corporation and Limelight Networks
>
> Modified:
> stable/10/sys/dev/ixgbe/if_ix.c
>
> Modified: stable/10/sys/dev/ixgbe/if_ix.c
> ==============================================================================
> --- stable/10/sys/dev/ixgbe/if_ix.c Thu Feb 11 16:16:10 2016 (r295524)
> +++ stable/10/sys/dev/ixgbe/if_ix.c Thu Feb 11 16:35:16 2016 (r295525)
> @@ -320,7 +320,8 @@ SYSCTL_INT(_hw_ix, OID_AUTO, enable_msix
> static int ixgbe_num_queues = 0;
> TUNABLE_INT("hw.ix.num_queues", &ixgbe_num_queues);
> SYSCTL_INT(_hw_ix, OID_AUTO, num_queues, CTLFLAG_RDTUN, &ixgbe_num_queues, 0,
> - "Number of queues to configure, 0 indicates autoconfigure");
> + "Number of queues to configure up to a mximum of 8,"
> + "0 indicates autoconfigure");
>
> /*
> ** Number of TX descriptors per ring,
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56BDC194.6070001>