Date: Sat, 28 May 2016 21:54:38 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r416053 - head/Mk/Uses Message-ID: <6084DC9FC0E493931C0C3D6B@atuin.in.mat.cc> In-Reply-To: <201605281719.u4SHJiAa008852@repo.freebsd.org> References: <201605281719.u4SHJiAa008852@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========6F8657D563B743C20E3F==========
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
+--On 28 mai 2016 17:19:44 +0000 Kurt Jaeger <pi@FreeBSD.org> wrote:
| Log:
| Mk/Uses/qmake.mk: add empty do-configure target
I'm going to pass on the commit message.
| .if !target(do-configure) && ! ${qmake_ARGS:M_env}
| -_USES_configure+= 450:qmake-configure
| +do-configure: qmake-configure
| + @${DO_NADA}
| .endif
I should explain a bit more.
This goes against the Right Way Of Doing Things(c)(r)(tm).
To add a target to be run in the targets pipeline, you use _USES_xxx, you
never, ever, piggyback on an existing target, especially if you're not
using it.
So, please, back this out.
--
Mathieu Arnold
--==========6F8657D563B743C20E3F==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJXSfd+XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I8uMP/jHCj9TVLzgKVwzDA6peKaSc
OyfJ+sWpOS7BVYXupjUoFqfVUqpTopTw4CYZLiTHYh7kpMjjY4pqWiunhd8HsPbc
XTZ4t7B/HmRfh1d9xEMnETsC/vq5xW9zDzgy0KnPN/0q9RVEdXodPSu/IVwD01tg
FDReTnxjCjliNraFYxxI7Corsm8qj4N72E8XdDi4oSFrmcMQMRfMjzy2yN7J7oK4
m88LwZK938raq2r+teNWTPHIVe8UAf1RemIU+Z+zDSklNJQu/tmVkMzqDpCbPqoo
gRAxwO/4mH77rpgNjA99+zSSfFL7S7t60NdRfzS8AkSUzE4ecFXLilPi2J9LVauD
Kdy90HBQjIyvMtgmT9YPxSi/HDXTtltyUDZUXyajv/3CkU1cB3ObVP9Yvp4/X8Rg
LrxUJnxMt3Pd9tkwDvL6w7zRfQiuU2X4bfYv0tsDNqUDqFWwAYpkHtOwD7/md1a7
FZ6gmAogQzCAemfujRp8y/vdk4uVqF7QS+c16ZVPvHDL3MJpmcy6NdW5lu0IlmkG
yG2X4Deg5Ia09Wg6YPhFwolPOS4RFk/EA98VWjjpHp2lE7WzGHJQdQyGNsmBdZPn
YXwixLII2wVZmcaPQhrUnChw7naY7UI6q971z1hKi31IPlt+RIf7lrS024/OhGxP
yhJjTKNIJ2MX7FCe/Z30
=9gkp
-----END PGP SIGNATURE-----
--==========6F8657D563B743C20E3F==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6084DC9FC0E493931C0C3D6B>