Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Oct 1995 23:57:03 -0700
From:      David Greenman <davidg@Root.COM>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org
Subject:   Re: cvs commit: src/sys/kern tty_pty.c 
Message-ID:  <199510260657.XAA00198@corbin.Root.COM>
In-Reply-To: Your message of "Thu, 26 Oct 95 05:11:25 %2B1000." <199510251911.FAA17483@godzilla.zeta.org.au> 

next in thread | previous in thread | raw e-mail | index | archive | help
>>  Modified:    sys/kern  tty_pty.c
>>  Log:
>>  Fixed data loss in writes to pty masters.  Data was almost always lost
>>  at the end of each write for writes of more than 1K.
>>  
>>  Fixed handling of residual count for early returns in writes to pty masters.
>>  It was only adjusted in 2 out of 6 cases.
>
>These changes should be in 2.1 too.  Sigh.  They should be checked more
>carefully than the changes in tty_subr.c.  I'm not sure what happens in
>the PF_REMOTE case.  cc can only be 0 in that case if the PF_REMOTE flag
>changed.  If that can happen, then cc may be too large to fit in the canq
>and not everything is written.

   I've been testing the changes here. These seem to fix the data loss
problems, but a cntrl-C still causes everything to wedge until I kill the
'od' in another window:

root       179   112   196  508 ptcout S     p0  11:54PM    0:01.71 od -v /dev/zero
root       180   112   184   68 ttywai SE+   p0  11:54PM    0:00.54 cat /dev/ttyp8


-DG



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199510260657.XAA00198>