Date: Sat, 3 Feb 2024 13:02:13 -0700 From: Warner Losh <imp@bsdimp.com> To: Kristof Provost <kp@freebsd.org> Cc: Gleb Smirnoff <glebius@freebsd.org>, "Bjoern A. Zeeb" <bz@freebsd.org>, =?UTF-8?Q?Mina_Gali=C4=87?= <freebsd@igalic.co>, Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, freebsd-arch@freebsd.org Subject: Re: git: ce348fe5cfc3 - main - amd64 & i386: enable VIMAGE in MINIMAL Message-ID: <CANCZdfr=DGKAFgRXbh47PvScrw2df3V9A2fA0yg3n_z61LbyJA@mail.gmail.com> In-Reply-To: <C511ABE5-A8F3-4DBD-AF8F-67B693686B3A@FreeBSD.org> References: <202402030136.4131aQIM010980@gitrepo.freebsd.org> <Zb3OC2IxxL8dlTUV@cell.glebi.us> <70o6oo0s-r8nn-7r92-5s6r-6so586rpo1o1@SerrOFQ.bet> <CANCZdfoBonTCdLNXR3AUt9KiQPQOgmf8A6A9cXd%2BQY05-h3sWQ@mail.gmail.com> <Zb5-2esmCaYSdGIg@cell.glebi.us> <C511ABE5-A8F3-4DBD-AF8F-67B693686B3A@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000078abad06107fb69b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Feb 3, 2024 at 12:07=E2=80=AFPM Kristof Provost <kp@freebsd.org> wr= ote: > On 3 Feb 2024, at 11:58, Gleb Smirnoff wrote: > > We just need at least one supported working kernel without VIMAGE (and > > probably other useful stuff, that is not useful to everyone). > > > Strong agree on this point. > > There are enough users out there who do not want VIMAGE (well, at least > one, but it=E2=80=99s enough of one to care), so we need to ensure it kee= ps > building. It=E2=80=99s very easy to forget about the non-VIMAGE case, and= if we > don=E2=80=99t have any kernel configs without we=E2=80=99re going to keep= breaking it and > not noticing until you run into it. > > That was even raised in the GitHub review. > MINIMAL is not a CI image to test things. It's a replacement for GENERIC that loads what one can. Its contents need to reflect that. That's why I did not give the issue weight. However,we likely need at a minimum LINT-NOVIMAGE like we have LINT-NOINET today. That's easy enough to arrange, and I'm happy to do it to cover the CI aspects of things. It kinda shows, though, that we may want to have more kernels with carefully thought out options to account for the different needs. I'll try to write up my thoughts on what they should be. I'm leaning to have an vm vs embedded vs server split as well as a load-it-all vs compile-it-in split, regardless of what they are named. And there's some base for all three and then extensions from there (vm and embedded may be the same, and server may be a superset of those two). So I'll take an action item to come up with a concrete proposal for these things, along with good definitions so people enhancing the system in the future have good guidance on wher to do that. Warner --00000000000078abad06107fb69b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Sat, Feb 3, 2024 at 12:07=E2=80=AF= PM Kristof Provost <<a href=3D"mailto:kp@freebsd.org">kp@freebsd.org</a>= > wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px = 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 3= Feb 2024, at 11:58, Gleb Smirnoff wrote:<br> > We just need at least one supported working kernel without VIMAGE (and= <br> > probably other useful stuff, that is not useful to everyone).<br> ><br> Strong agree on this point.<br> <br> There are enough users out there who do not want VIMAGE (well, at least one= , but it=E2=80=99s enough of one to care), so we need to ensure it keeps bu= ilding. It=E2=80=99s very easy to forget about the non-VIMAGE case, and if = we don=E2=80=99t have any kernel configs without we=E2=80=99re going to kee= p breaking it and not noticing until you run into it.<br> <br> That was even raised in the GitHub review.<br></blockquote></div><div class= =3D"gmail_quote"><br></div><div class=3D"gmail_quote">MINIMAL is not a CI i= mage to test things. It's a replacement for GENERIC that loads what one= can. Its contents need to reflect that. That's why I did not give the = issue weight. However,we likely need at a minimum LINT-NOVIMAGE like we hav= e LINT-NOINET today. That's easy enough to arrange, and I'm happy t= o do it to cover the CI aspects of things.<br></div><div class=3D"gmail_quo= te"><div><br></div><div>It kinda shows, though, that we may want to have mo= re kernels with carefully thought out options to account for the different = needs.=C2=A0 I'll try to write up my thoughts on what they should be. I= 'm leaning to have an vm vs embedded vs server split as well as a load-= it-all vs compile-it-in split, regardless of what they are named. And there= 's some base for all three and then extensions from there (vm and embed= ded may be the same, and server may be a superset of those two). So I'l= l take an action item to come up with a concrete proposal for these things,= along with good definitions so people enhancing the system in the future h= ave good guidance on wher to do that.<br></div><div><br></div><div>Warner<b= r></div></div></div> --00000000000078abad06107fb69b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr=DGKAFgRXbh47PvScrw2df3V9A2fA0yg3n_z61LbyJA>