Date: Wed, 06 Jan 1999 10:40:22 +0900 From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> To: billf@jade.chc-chimes.com Cc: kkennawa@physics.adelaide.edu.au, simokawa@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, ports@FreeBSD.ORG Subject: Re: cvs commit: ports/graphics/giftrans Makefile ports/graphics/mpeg2codec/patches patch-aa ports/graphics/splitmpg/patches patch-aa ports/graphics/xdl/patches patch-aa Message-ID: <19990106104022O.simokawa@sat.t.u-tokyo.ac.jp> In-Reply-To: Your message of "Tue, 5 Jan 1999 15:54:10 -0500 (EST)" <Pine.BSF.3.96.990105155235.29309A-100000@jade.chc-chimes.com> References: <Pine.BSF.3.96.990105155235.29309A-100000@jade.chc-chimes.com>
next in thread | previous in thread | raw e-mail | index | archive | help
billf> > On Mon, 4 Jan 1999, Hidetoshi Shimokawa wrote:
billf> >
billf> > > Log:
billf> > > remove -m486 option for alpha.
billf>
billf> I'd like to second Kris's comments on CFLAGS (again.) If you(or anyone)
billf> are taking the time to go through and make these ports kosher for Alpha,
billf> you should also be making them respect the system CFLAGS.
O.K. I should think more about it.
He suggested to chage from:
CFLAGS = -O2 -Dfoo -Dbar
to:
CFLAGS ?= -O2
CFLAGS += -Dfoo -Dbar
But as far as I understand, CFLAGS is always set at sys.mk even if
you don't set it in make.conf. So the line "CFLAGS ?= -O2" has no effect.
(If you run gmake directly, it is not the case)
Try this Makefile:
CFLAGS ?= -use_this
CFLAGS += -addional_flags
all:
@echo ${CFLAGS}
Then, it seems sufficient that we remove *all* optimization and machine
dependent flags and change "=" to "+=".
CFLAGS += -Dfoo -Dbar
Respecting system CFLAGS means ignoring application's optimization flags
completely... (we may be able to do something in ports Makefile)
If this is right, I will remove all optimization flags next time.
/\ Hidetoshi Shimokawa
\/ simokawa@sat.t.u-tokyo.ac.jp
PGP public key: finger -l simokawa@sat.t.u-tokyo.ac.jp
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990106104022O.simokawa>