Date: Fri, 23 Mar 2018 13:45:11 +0100 From: "Gabor Kovesdan" <gabor@kovesdan.org> To: "Mathieu Arnold" <mat@FreeBSD.org> Cc: "Gabor Kovesdan" <gabor@mypc.hu>, "Mathieu Arnold" <mat@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r465284 - head/x11-fonts/lohit Message-ID: <05db9f47f88edf0e15a5b554044d194f.squirrel@webmail.mypc.hu> In-Reply-To: <20180322115028.7qi7q65pvricwv7b@ogg.in.absolight.net> References: <201803221025.w2MAPK8R092414@repo.freebsd.org> <1a18c2f5-9151-6d2c-fd98-3d5aee9a13c4@mypc.hu> <20180322115028.7qi7q65pvricwv7b@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Thu, Mar 22, 2018 at 11:46:18AM +0100, Gabor Kovesdan wrote: >> >> >> On 3/22/2018 11:25 AM, Mathieu Arnold wrote: >> > Author: mat Date: Thu Mar 22 10:25:20 2018 New Revision: 465284 >> > URL: https://svnweb.freebsd.org/changeset/ports/465284 >> > >> > Log: Fix previous commit. >> > >> > Pointy hat: gabor Sponsored by: Absolight >> > >> > Modified: head/x11-fonts/lohit/Makefile (contents, props >> > changed) >> > >> > Modified: head/x11-fonts/lohit/Makefile >> > ============================================================================== >> > >> > >> --- head/x11-fonts/lohit/Makefile Thu Mar 22 10:14:11 2018 (r465283) >> > +++ head/x11-fonts/lohit/Makefile Thu Mar 22 10:25:20 2018 >> > (r465284) @@ -2,6 +2,7 @@ >> > >> > PORTNAME= Lohit PORTVERSION= 20140220 +PORTREVISION= 1 CATEGORIES= >> > x11-fonts MASTER_SITES= https://releases.pagure.org/lohit/ >> > DISTNAME= lohit-ttf-${PORTVERSION} @@ -22,7 +23,6 @@ PLIST_FILES= >> > ${FONTSDIR}/Lohit-Assamese.ttf \ ${FONTSDIR}/Lohit-Kannada.ttf \ >> > ${FONTSDIR}/Lohit-Malayalam.ttf \ ${FONTSDIR}/Lohit-Marathi.ttf \ >> > -# ${FONTSDIR}/Lohit-Nepali.ttf \ ${FONTSDIR}/Lohit-Oriya.ttf \ >> > ${FONTSDIR}/Lohit-Punjabi.ttf \ >> > ${FONTSDIR}/Lohit-Tamil-Classical.ttf \ >> > >> >> New version lacks the Nepali font, it wasn't commented out by mistake. >> Please revert. > > I will not revert a fix. The new version you committed also lacked Oriya > Punjabi Tamil-Classical Tamil Telugu, whatever those are. > > If you write: > > FOO= a \ > # b \ > c > > What makes understand is "FOO= a # b c". > So FOO only contains "a", not "a c". > > If you want to put back the line I removed to fix your error (which > means that obviously, neither you, nor the submitter ever tested the > patch), you can put it back, but AFTER the list. Sorry, you're right, I only tested manually and I didn't catch this... Gabor
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?05db9f47f88edf0e15a5b554044d194f.squirrel>