Date: Fri, 23 Nov 2018 14:21:55 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r485586 - head/java/netty Message-ID: <20181123132155.quhjbh2inyq3zfug@ogg.in.absolight.net> In-Reply-To: <20181123124845.GA50746@FreeBSD.org> References: <201811220930.wAM9URj7056367@repo.freebsd.org> <20181122095930.fnfd4gpowkqehznp@atuin.in.mat.cc> <20181122125524.GA37389@hades.panopticon> <20181122161928.md57g2b2y7ctvkdb@atuin.in.mat.cc> <20181123124845.GA50746@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--rzflnkneyey5r66a
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Nov 23, 2018 at 12:48:45PM +0000, Alexey Dokuchaev wrote:
> On Thu, Nov 22, 2018 at 05:19:28PM +0100, Mathieu Arnold wrote:
> > On Thu, Nov 22, 2018 at 03:55:24PM +0300, Dmitry Marakasov wrote:
> > > * Mathieu Arnold (mat@FreeBSD.org) wrote:
> > > > > -PLIST_FILES=3D %%JAVAJARDIR%%/netty-${PORTVERSION}.jar \
> > > > > - %%JAVAJARDIR%%/netty.jar
> > > > > +PLIST_FILES=3D ${JAVAJARDIR:S,^${PREFIX}/,,}/netty-${PORTVERSION=
}.jar \
> > > > > + ${JAVAJARDIR:S,^${PREFIX}/,,}/netty.jar
> > > >=20
> > > > This seems overly complicated. What is wrong with having just
> > > > ${JAAAVJARDIR}?
> > >=20
> > > It contains absolute path. I've assumed we don't use these in the pli=
st.
> >=20
> > Paths in the PLIST are either relative to PREFIX or absolute. If a path
> > is absolute and starts with PREFIX, it is just fine.
>=20
> Absolute paths, however, look ugly in PLIST, and generally do not sound
> like a good idea (e.g., how well do they align with relocatable packages)?
Have a look at the content of a package, all the files in them have full
paths. Relocation works by doing a s|^/usr/local|/bar|. =20
As for the ugly, well, I find ${JAVAJARDIR:S,^${PREFIX}/,,} much worse
than having full path that you will never see because it is hidden
in variables.
--=20
Mathieu Arnold
--rzflnkneyey5r66a
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlv3/vJfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkhPog//VCco1RsslrpwDchEQQ8SqXkxKKnCh+JEI/Qw/hy4Z6xIHOSw6RO4cj72
ASIGG8Zpn0Ihx0rPfmsXFgdbK1jFNIe6kssOk6Cc28Ci3DUzQShmhwUmOJ/kPyrY
HVbu/idgVMn8xAVKshzDtVw/jQIPkTEhaXCvFIoGD4cZFEIVmV6T/UwM39/Z33L6
a36vIoH4JTpLleGjnzTXjPKuuZczxhAaJRCP69SuF8EIwTQ/tNtddbe7QVYJd/0E
Hj4BTmbCbeGDSp2KGciTJSpb5/DXf5jDM1S5nLy7SNEB46T6zESin6JyZE66NUXB
FFNPzqNv3rmTiwXLatpKdXLM6tmIZ65t0+LosX3u/TvW6SfAFPYJRYsGf8anEfQH
OCxt1wCdPzXPceUXtnm4rube9HxxIjOtAuoJfgop4V0AufIYzr1oGbHisOvrw/Q9
n0rIHHpTYuGCfs4URa/4PMGiisiAdpu2KKrQ+t4A5dbw5RgKjkoPwP2HiUlH6I+P
amK8y4L1XNWNtBts2K4dm0KA0t1B4gNVCxhHoNSNluEvRwfFYakRDZqef9k5R9sO
muReygBs0D3ooDAjsF9faRVwEsZ9yPO+76geOkWtsYmz+lVdjkLKAHx4fx/fUpbO
yGRJgkGQg+zw7RWgozcO2Nl8OyhIMu90ZYmtdq+KZ3+mTeaM2HE=
=w76m
-----END PGP SIGNATURE-----
--rzflnkneyey5r66a--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181123132155.quhjbh2inyq3zfug>