Date: Thu, 27 Nov 2003 01:26:53 +0300 From: Sergey Matveychuk <sem@ciam.ru> To: ports@FreeBSD.org, marcus@freebsd.org Subject: PORTVERSION and portlint Message-ID: <3FC528AD.2050108@ciam.ru>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------080305060701010604070500
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
What's wrong with '+' sign in PORTVERSION?
www/apache13+modssl, russian/apache* and dns/bind9-dlz ports use it for
separating port version and module version. I think it's a good practice.
But portlint marks it as FATAL. May be make a sense this simple patch to
apply?
---
Sem.
--------------080305060701010604070500
Content-Type: text/plain;
name="portlint.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="portlint.patch"
--- portlint.orig Thu Nov 27 01:22:30 2003
+++ portlint Thu Nov 27 01:23:04 2003
@@ -1535,7 +1535,7 @@
&perror("FATAL: $file: PORTVERSION must be specified");
}
if ($portversion =~ /^pl[0-9]*$/
- || $portversion =~ /^[0-9]*[A-Za-z]?[0-9]*(\.[0-9]*[A-Za-z]?[0-9]*)*$/) {
+ || $portversion =~ /^[0-9]*[A-Za-z]?[0-9]*(\.[0-9]*[A-Za-z]?[0-9+]*)*$/) {
print "OK: PORTVERSION \"$portversion\" looks fine.\n" if ($verbose);
} elsif ($portversion =~ /^[^\-]*\$[{\(].+[\)}][^\-]*$/) {
&perror("WARN: $file: using variable, \"$portversion\", as version ".
--------------080305060701010604070500--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3FC528AD.2050108>