Date: Tue, 17 Aug 2021 11:51:12 -0400 From: Ed Maste <emaste@freebsd.org> To: Wojciech Macek <wma@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: e8ad0a0059af - main - ipmi: New tunable to deactivate IPMI watchdog Message-ID: <CAPyFy2AbaZ8rCx5qhxXKaDuszAQXFop44i9dfOMEAhNH-ZMECw@mail.gmail.com> In-Reply-To: <202108170631.17H6VrAE094329@gitrepo.freebsd.org> References: <202108170631.17H6VrAE094329@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 17 Aug 2021 at 02:31, Wojciech Macek <wma@freebsd.org> wrote: > > The branch main has been updated by wma: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e8ad0a0059afe1cd0af39bab49018ae7bc9be937 > > commit e8ad0a0059afe1cd0af39bab49018ae7bc9be937 > Author: Wojciech Macek <wma@FreeBSD.org> > AuthorDate: 2021-08-17 06:28:21 +0000 > Commit: Wojciech Macek <wma@FreeBSD.org> > CommitDate: 2021-08-17 06:31:00 +0000 > > ipmi: New tunable to deactivate IPMI watchdog A bit of post-commit review: >From sysctl.9: "For boolean sysctls, negative logic should be totally avoided. That is, do not use names like no_foobar or foobar_disable. They are confusing and lead to configuration errors. Use positive logic instead: foobar, foobar_enable." So, preferable to have wd_init_enable = 1 instead. > +SYSCTL_INT(_hw_ipmi, OID_AUTO, wd_init_disable, CTLFLAG_RWTUN, > + &wd_init_disable, 0, ""); and we should have a description here.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2AbaZ8rCx5qhxXKaDuszAQXFop44i9dfOMEAhNH-ZMECw>