Date: Fri, 20 Aug 2004 21:47:48 +0000 (UTC) From: Don Lewis <truckman@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern kern_module.c Message-ID: <200408202147.i7KLlmPR040923@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
truckman 2004-08-20 21:47:48 UTC
FreeBSD src repository
Modified files:
sys/kern kern_module.c
Log:
Don't bother calling the module event handlers from module_shutdown()
in the shutdown_final state if the RB_NOSYNC flag is set.
The specific motivation in this case is that a system panic in an
interrupt context results in a call to module_shutdown(), which
calls g_modevent(), which calls g_malloc(..., M_WAITOK), which
results in a second panic. While g_modevent() could be fixed to
not call malloc() for MOD_SHUTDOWN events (which it doesn't handle
in any case), it is probably also a good idea to entirely skip the
execution of the module shutdown handlers after a panic.
This may be a MFC candidate for RELENG_5.
Revision Changes Path
1.46 +3 -0 src/sys/kern/kern_module.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200408202147.i7KLlmPR040923>