Date: Sun, 7 Sep 2014 09:44:37 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Mateusz Guzik <mjguzik@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r271182 - head/sys/kern Message-ID: <20140907054437.GI17059@FreeBSD.org> In-Reply-To: <20140905195410.GA722@dft-labs.eu> References: <201409051950.s85JoI3r000416@svn.freebsd.org> <20140905195410.GA722@dft-labs.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 05, 2014 at 09:54:11PM +0200, Mateusz Guzik wrote: M> > + CURVNET_SET(so->so_vnet); M> > if (V_socket_hhh[HHOOK_FILT_SOREAD]->hhh_nhooks > 0) M> > /* This hook returning non-zero indicates an event, not error */ M> > return (hhook_run_socket(so, NULL, HHOOK_FILT_SOREAD)); M> > + CURVNET_RESTORE(); M> > M> M> should not this be something like: M> error = hhook_run_socket(so, NULL, HHOOK_FILT_SOREAD); M> CURVNET_RESTORE(); M> return (error); M> ? Thanks, Mateusz. Fixed. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140907054437.GI17059>