Date: Mon, 7 Dec 2020 13:11:10 -0600 From: Kyle Evans <kevans@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Steve Wills <swills@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r368005 - in head: lib/libprocstat share/man/man4 sys/opencrypto sys/sys tools/tools/crypto usr.bin/procstat Message-ID: <CACNAnaH8ZhXcS-UJSvKKqeR8wmuA3Fbt3ntVeTX=5Nc2wYTJew@mail.gmail.com> In-Reply-To: <43f82b24-a1d0-8e48-a405-58e8bbda0c12@FreeBSD.org> References: <202011250010.0AP0AtH3061986@repo.freebsd.org> <9f48b622-2596-f3c4-0aff-f0b57e8022ea@FreeBSD.org> <43f82b24-a1d0-8e48-a405-58e8bbda0c12@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On Mon, Dec 7, 2020 at 12:58 PM John Baldwin <jhb@freebsd.org> wrote: > > On 12/6/20 8:51 PM, Steve Wills wrote: > > Hi, > > > > On 11/24/20 7:10 PM, John Baldwin wrote: > >> Author: jhb > >> Date: Wed Nov 25 00:10:54 2020 > >> New Revision: 368005 > >> URL: https://svnweb.freebsd.org/changeset/base/368005 > >> > >> Log: > >> Remove the cloned file descriptors for /dev/crypto. > >> > > > > Would this change warrant a bump of __FreeBSD_version? I only noticed > > because PR 251470 (radare2 not building due to KF_TYPE_CRYPTO). > > Hmm, perhaps so, though ports could also use #ifdef KF_TYPE_CRYPTO (and > that is probably preferred for anything using C). Looks like we haven't > yet had another bump of __FreeBSD_version so I can do that. > There's surely a better way, but this version bump would've actually been really handy for detecting the resulting qemu-user-static fallout. The build was broken for about ~9 days, neither the official builder or my local builder felt compelled to rebuild it absent the bump because I had just built it a couple revisions prior. =-( I'm kind of leaning towards trying to shoehorn a qemu-user-static build into ci.f.o somewhere, though, since it's used as a part of producing some of the weekly snapshot images and digs pretty deeply in other areas. I've got a Cirrus config for qemu-user-static and Cirrus builds it regularly for me, but that's not so helpful when the image it builds against is also tied to the weekly snapshot process. Thanks, Kyle Evanshome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaH8ZhXcS-UJSvKKqeR8wmuA3Fbt3ntVeTX=5Nc2wYTJew>