Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Jul 2024 20:39:05 GMT
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 0ac6cc3fd747 - main - iichid: Soften "Interrupt setup failed" message
Message-ID:  <202407232039.46NKd5LU054602@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=0ac6cc3fd7473a7a8596fa73322a67fc1d78df53

commit 0ac6cc3fd7473a7a8596fa73322a67fc1d78df53
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-07-23 17:37:15 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-07-23 20:38:16 +0000

    iichid: Soften "Interrupt setup failed" message
    
    Users may interpret the message as a possible hardware error, but the
    issue is in fact unimplemented functionality.  Reword the message to
    avoid implying it is an error.
    
    Reviewed by:    wulf
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D46092
---
 sys/dev/iicbus/iichid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/iicbus/iichid.c b/sys/dev/iicbus/iichid.c
index 222f20842a04..1e0dac2ee5dd 100644
--- a/sys/dev/iicbus/iichid.c
+++ b/sys/dev/iicbus/iichid.c
@@ -1154,7 +1154,7 @@ iichid_attach(device_t dev)
 	if (sc->irq_res == NULL || error != 0) {
 #ifdef IICHID_SAMPLING
 		device_printf(sc->dev,
-		    "Interrupt setup failed. Fallback to sampling\n");
+		    "Using sampling mode\n");
 		sc->sampling_rate_slow = IICHID_SAMPLING_RATE_SLOW;
 #else
 		device_printf(sc->dev, "Interrupt setup failed\n");



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202407232039.46NKd5LU054602>