Date: Sun, 31 Aug 2008 20:10:41 +0100 From: Rui Paulo <rpaulo@FreeBSD.org> To: Stanislav Sedov <stas@FreeBSD.org> Cc: Rui Paulo <rpaulo@FreeBSD.org>, freebsd-drivers@freebsd.org, Pyun YongHyeon <yongari@FreeBSD.org> Subject: Re: [Review request]: Attansic L2 ethernet driver Message-ID: <20080831191041.GA97323@alpha.local> In-Reply-To: <20080831222822.76d4ee92.stas@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On Sun, Aug 31, 2008 at 10:28:22PM +0400, Stanislav Sedov wrote: > Hi! > > Seems that I've implemented the most stuff I wanted > to see in the driver for Attansic L2 ethernet controller. > I haven't received any bugreports since the last public > version and I think it's in a pretty good form and ready > to be committed in HEAD. Before that, I'd like to ask > you to review the code of the driver, since it's my > first work in this area, and I'm not sure I've done > everything correctly. > > The latest diff against HEAD is available here: > http://www.SpringDaemons.com/stas/if_ae.diff.2008083100 * ae_init_tunables() - Is this the correct name for this function? * I think you don't want to go over 80 columns and there are several places where you go. The rest looks fine. Thanks, -- Rui Paulohome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080831191041.GA97323>