Date: Wed, 1 Jan 2025 00:32:11 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 45b52cec21e6 - main - www/node18: Fix build with icu 76.1 Message-ID: <CAMHz58TzOPg8CuvDTgzxQ1iirSE1u%2B3U%2BLp4YG7zFov3r9QtUw@mail.gmail.com> In-Reply-To: <202412311605.4BVG5hdL001263@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Jan 1, 2025 at 12:06 AM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote: > The branch main has been updated by sunpoet: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=45b52cec21e67673c5990eded07125f873839e55 > > commit 45b52cec21e67673c5990eded07125f873839e55 > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > AuthorDate: 2024-12-31 15:57:15 +0000 > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > CommitDate: 2024-12-31 15:57:15 +0000 > > www/node18: Fix build with icu 76.1 > PR: 283566 > It should be: www/node20: Fix build with icu 76.1 PR: 283567 Reported by: diizzy > Obtained from: > https://github.com/nodejs/node/commit/81517faceac86497b3c8717837f491aa29a5e0f9 > --- > www/node20/files/patch-icu | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/www/node20/files/patch-icu b/www/node20/files/patch-icu > new file mode 100644 > index 000000000000..13dbbdccc8fd > --- /dev/null > +++ b/www/node20/files/patch-icu > @@ -0,0 +1,13 @@ > +Obtained from: > https://github.com/nodejs/node/commit/81517faceac86497b3c8717837f491aa29a5e0f9 > + > +--- configure.py.orig 2024-11-20 13:28:19 UTC > ++++ configure.py > +@@ -1829,7 +1829,7 @@ def configure_intl(o): > + elif with_intl == 'system-icu': > + # ICU from pkg-config. > + o['variables']['v8_enable_i18n_support'] = 1 > +- pkgicu = pkg_config('icu-i18n') > ++ pkgicu = pkg_config(['icu-i18n', 'icu-uc']) > + if not pkgicu[0]: > + error('''Could not load pkg-config data for "icu-i18n". > + See above errors or the README.md.''') > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr">On Wed, Jan 1, 2025 at 12:06 AM Po-Chuan Hsieh <<a href="mailto:sunpoet@freebsd.org">sunpoet@freebsd.org</a>> wrote:<br></div><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by sunpoet:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=45b52cec21e67673c5990eded07125f873839e55" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=45b52cec21e67673c5990eded07125f873839e55</a><br>; <br> commit 45b52cec21e67673c5990eded07125f873839e55<br> Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> AuthorDate: 2024-12-31 15:57:15 +0000<br> Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> CommitDate: 2024-12-31 15:57:15 +0000<br> <br> www/node18: Fix build with icu 76.1</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> PR: 283566<br></blockquote><div><br></div><div>It should be:<br></div><div><br></div><div><div>www/node20: Fix build with icu 76.1</div></div><div><br></div><div>PR: 283567</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Reported by: diizzy<br> Obtained from: <a href="https://github.com/nodejs/node/commit/81517faceac86497b3c8717837f491aa29a5e0f9" rel="noreferrer" target="_blank">https://github.com/nodejs/node/commit/81517faceac86497b3c8717837f491aa29a5e0f9</a><br>; ---<br> www/node20/files/patch-icu | 13 +++++++++++++<br> 1 file changed, 13 insertions(+)<br> <br> diff --git a/www/node20/files/patch-icu b/www/node20/files/patch-icu<br> new file mode 100644<br> index 000000000000..13dbbdccc8fd<br> --- /dev/null<br> +++ b/www/node20/files/patch-icu<br> @@ -0,0 +1,13 @@<br> +Obtained from: <a href="https://github.com/nodejs/node/commit/81517faceac86497b3c8717837f491aa29a5e0f9" rel="noreferrer" target="_blank">https://github.com/nodejs/node/commit/81517faceac86497b3c8717837f491aa29a5e0f9</a><br>; +<br> +--- configure.py.orig 2024-11-20 13:28:19 UTC<br> ++++ configure.py<br> +@@ -1829,7 +1829,7 @@ def configure_intl(o):<br> + elif with_intl == 'system-icu':<br> + # ICU from pkg-config.<br> + o['variables']['v8_enable_i18n_support'] = 1<br> +- pkgicu = pkg_config('icu-i18n')<br> ++ pkgicu = pkg_config(['icu-i18n', 'icu-uc'])<br> + if not pkgicu[0]:<br> + error('''Could not load pkg-config data for "icu-i18n".<br> + See above errors or the README.md.''')<br> </blockquote></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58TzOPg8CuvDTgzxQ1iirSE1u%2B3U%2BLp4YG7zFov3r9QtUw>