Date: Sun, 22 Aug 2010 01:39:09 +0000 (UTC) From: Pyun YongHyeon <yongari@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h Message-ID: <201008220139.o7M1dLl6015063@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
yongari 2010-08-22 01:39:09 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c if_bgereg.h Log: SVN rev 211596 on 2010-08-22 01:39:09Z by yongari It seems all Broadcom controllers have a bug that can generate UDP datagrams with checksum value 0 when TX UDP checksum offloading is enabled. Generating UDP checksum value 0 is RFC 768 violation. Even though the probability of generating such UDP datagrams is low, I don't want to see FreeBSD boxes to inject such datagrams into network so disable UDP checksum offloading by default. Users still override this behavior by setting a sysctl variable or loader tunable, dev.bge.%d.forced_udpcsum. I have no idea why this issue was not reported so far given that bge(4) is one of the most commonly used controller on high-end server class systems. Thanks to andre@ who passed the PR to me. PR: kern/104826 Revision Changes Path 1.296 +41 -7 src/sys/dev/bge/if_bge.c 1.101 +2 -0 src/sys/dev/bge/if_bgereg.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008220139.o7M1dLl6015063>