Date: Sun, 21 Dec 2014 12:28:04 -0700 From: Adam Weinberger <adamw@adamw.org> To: Steve Wills <swills@FreeBSD.org> Cc: "svn-ports-head@FreeBSD.org" <svn-ports-head@FreeBSD.org>, "svn-ports-all@FreeBSD.org" <svn-ports-all@FreeBSD.org>, "ports-committers@FreeBSD.org" <ports-committers@FreeBSD.org> Subject: Re: svn commit: r375010 - head/Mk Message-ID: <C23602A5-9FEA-4180-B469-4E098F16003C@adamw.org> In-Reply-To: <549707F1.4070205@FreeBSD.org> References: <201412201559.sBKFxl9d088764@svn.freebsd.org> <46210F48-0FE2-4B61-AA64-17472B9EAEEB@adamw.org> <549707F1.4070205@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Dec 21, 2014, at 10:48, Steve Wills <swills@FreeBSD.org> wrote: >=20 > On 12/21/14 15:15, Adam Weinberger wrote: >>> On 20 Dec, 2014, at 8:59, Steve Wills <swills@freebsd.org> >>> wrote: >>>=20 >>> Author: swills Date: Sat Dec 20 15:59:46 2014 New Revision: >>> 375010 URL: https://svnweb.freebsd.org/changeset/ports/375010=20 >>> QAT: https://qat.redports.org/buildarchive/r375010/ >>>=20 >>> Log: Make using GitHub releases easier >>>=20 >>> Differential Revision: https://reviews.freebsd.org/D1340 With >>> hat: portmgr >>>=20 >>> -# -# GitHub files can also be obtained, without the need for any >>> of the above, by doing: -# -# MASTER_SITES=3D >>> http://github.com/accountname/${PORTNAME}/archive/${PORTVERSION}.tar.gz?= dummy=3D/ > -# >>=20 >> That shortcut code still works, and it's still simpler than using=20 >> USE_GITHUB and having to keep track of commit hashes on every >> update. Why remove it? >>=20 >> The PH says, "If the distribution file comes from a specific >> commit or tag on GitHub for which there is no officially released >> file, [...]". That code block is a way to get it when there IS an=20 >> officially released file. >=20 > Wouldn't you still have to do work to update the distinfo if the > commit hash changes? Sure, same as other ports. Only difference is that, same as other ports, you= don't need to come up with the commit SHA hash as well. You're portmgr, it'= s your call of course, I just thought it was a nice alternative for ports wi= th release tarballs on github to use a simpler method. # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C23602A5-9FEA-4180-B469-4E098F16003C>