Date: Mon, 6 Mar 2017 19:15:08 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: rgrimes@freebsd.org Cc: Ngie Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r314819 - stable/11/lib/libutil Message-ID: <699FBEE3-2379-414E-9E50-C3F726212949@gmail.com> In-Reply-To: <1DB4959E-059E-40FB-96EB-67DCDE9BBAA0@gmail.com> References: <201703070300.v2730N2F091879@pdx.rh.CN85.dnsmgr.net> <1DB4959E-059E-40FB-96EB-67DCDE9BBAA0@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Mar 6, 2017, at 19:10, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > >> >> On Mar 6, 2017, at 19:00, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: >> >> [ Charset UTF-8 unsupported, converting... ] >>> Author: ngie >>> Date: Tue Mar 7 01:58:39 2017 >>> New Revision: 314819 >>> URL: https://svnweb.freebsd.org/changeset/base/314819 >>> >>> Log: >>> MFC r313438: >>> >>> Clean up trailing and leading whitespace for variables to make it >>> consistent with the rest of the file and style.Makefile(9) a bit >>> more >>> >>> Modified: >>> stable/11/lib/libutil/Makefile >>> Directory Properties: >>> stable/11/ (props changed) >>> >>> Modified: stable/11/lib/libutil/Makefile >>> ============================================================================== >>> --- stable/11/lib/libutil/Makefile Tue Mar 7 01:52:56 2017 (r314818) >>> +++ stable/11/lib/libutil/Makefile Tue Mar 7 01:58:39 2017 (r314819) >>> @@ -35,7 +35,7 @@ MAN+= expand_number.3 flopen.3 fparseln. >>> property.3 pty.3 quotafile.3 realhostname.3 realhostname_sa.3 \ >>> _secure_path.3 trimdomain.3 uucplock.3 pw_util.3 >>> MAN+= login.conf.5 >>> -MLINKS+= kld.3 kld_isloaded.3 kld.3 kld_load.3 >>> +MLINKS+=kld.3 kld_isloaded.3 kld.3 kld_load.3 >>> MLINKS+=login_auth.3 auth_cat.3 login_auth.3 auth_checknologin.3 >>> MLINKS+=login_cap.3 login_close.3 login_cap.3 login_getcapbool.3 \ >> >> Thats actually counter style.Makefile(9), Normally you have a tab here, >> or a space should the variable name extend beyond column 9. >> >>> login_cap.3 login_getcaplist.3 login_cap.3 login_getcapnum.3 \ >>> @@ -57,9 +57,9 @@ MLINKS+=pidfile.3 pidfile_close.3 \ >>> pidfile.3 pidfile_open.3 \ >>> pidfile.3 pidfile_remove.3 \ >>> pidfile.3 pidfile_write.3 >>> -MLINKS+= property.3 property_find.3 property.3 properties_free.3 >>> -MLINKS+= property.3 properties_read.3 >>> -MLINKS+= pty.3 forkpty.3 pty.3 openpty.3 >>> +MLINKS+=property.3 property_find.3 property.3 properties_free.3 >>> +MLINKS+=property.3 properties_read.3 >>> +MLINKS+=pty.3 forkpty.3 pty.3 openpty.3 >> >> Ditto. > > Yeah, I tried to leave things alone (except is surrounding areas for the following change), but I’ll go and hack away at the Makefile some more. > Thanks, Actually, on second thought, I’m not going to modify the Makefile to just introduce gratuitous whitespace. If I need to touch this again, I’ll do it, but it doesn’t make sense churning over this Makefile like that (it’s a mishmash of different “styles”). Thanks, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYviW8AAoJEPWDqSZpMIYVGiUP/3uyhF0Q75I8cK8eJ6gGlXYF EHt9eMwl9tarylGmAvhJXvTXsPBpQ8AfzqfmDvRkVq72iUBWuZVWOgyhoDTL+VsK HM4U/6WSntxlGxLOEIu2l1jRR5G0zQQCtoECDxZvL8b8ZXWunbQvNpG8ubLUjKy8 rN7jSWs9mJ0lHW6AcmRoImTRkrvjhkJITsxTLNfzyZxn+0IiJbxhjFi1pZtLNrXe b//d4ATjtjv1CKnQ1dkWTaDPoKAsOVp80ZlJLGRiyQ3nWSxBQ6AGaKGsdTK2qgl6 3ve/73n9x48kf2Seb+9UvQ6gniluDzeKKBlXQcilQL1q8rg58XMHqoFyPhoTvu07 /KVljo5zgFnHhAcLK1rHTlkBbVh0YecFoFa+BFexB784oz+ghGAYsTPoNARJNm48 cUB7MkPtBBJwa/DJWxvUYgelY0+XSsuNNrrRuKksIe82uD9lPufJxwxp6+Czx4/l rSV7jgwqUee6qPH9WIslRu1kFS3AhBus6l3Swi2DM/Z4ajXOuTWWXfo99G6NIlpv eRsP0Ih4dsT80DCO3wr+67p7uwcE5vtH8Du3XgDJXl4fCLNUfkJPslgj9PQAecuD g+wfR6Ko72Fq8bd66Pc8y015jZ6WKhZ0zRtqcHnE6k8F74nzgzwjXE2KPIstdQiR 8C374qQmtvAGZiXIirna =+6t9 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?699FBEE3-2379-414E-9E50-C3F726212949>