Date: Thu, 2 Mar 2017 23:15:21 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Hiroki Sato <hrs@FreeBSD.org> Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314585 - head/usr.sbin/syslogd Message-ID: <1A3F6606-822C-4C80-ADFA-48378F0F29EE@gmail.com> In-Reply-To: <3B6DBB8E-B9AF-46DF-BDEA-9D51DF132BA6@gmail.com> References: <201703030613.v236DxDl010255@repo.freebsd.org> <20170303.154955.607107599855581369.hrs@allbsd.org> <3B6DBB8E-B9AF-46DF-BDEA-9D51DF132BA6@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Mar 2, 2017, at 23:13, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > >> >> On Mar 2, 2017, at 22:49, Hiroki Sato <hrs@FreeBSD.org> wrote: >> >> Ngie Cooper <ngie@FreeBSD.org> wrote >> in <201703030613.v236DxDl010255@repo.freebsd.org>: >> >> ng> Author: ngie >> ng> Date: Fri Mar 3 06:13:59 2017 >> ng> New Revision: 314585 >> ng> URL: https://svnweb.freebsd.org/changeset/base/314585 >> ng> >> ng> Log: >> ng> Correct verb change for service => `*` after r314563 >> ng> >> ng> `*` means that packets will be received from a remote peer on any port. >> ng> Since the point of interest is the syslogd instance (not the remote peer), >> ng> the appropriate verb is "received", not "sent". >> ng> >> ng> MFC after: 1 month >> ng> X-MFC with: r314563 >> ng> Sponsored by: Dell EMC Isilon >> ng> >> ng> Modified: >> ng> head/usr.sbin/syslogd/syslogd.8 >> ng> >> ng> Modified: head/usr.sbin/syslogd/syslogd.8 >> ng> ============================================================================== >> ng> --- head/usr.sbin/syslogd/syslogd.8 Fri Mar 3 06:06:27 2017 (r314584) >> ng> +++ head/usr.sbin/syslogd/syslogd.8 Fri Mar 3 06:13:59 2017 (r314585) >> ng> @@ -131,7 +131,7 @@ A >> ng> .Ar service >> ng> of >> ng> .Ql \&* >> ng> -allows packets to be sent from any UDP port. >> ng> +allows packets to be received from any UDP port. >> ng> The default >> ng> .Ar service >> >> It is incorrect that syslogd receives a UDP packet on any local port >> when a "*" is specified. This address validation is done by using >> the source port number in a received UDP packet, so the point of >> interest is the remote peer. >> >> How about "...accepts UDP packets sent with any source port" or >> something? > > Yeah, that’s more accurate. How about this? -Ngie $ svn diff usr.sbin/syslogd/syslogd.8 Index: usr.sbin/syslogd/syslogd.8 =================================================================== --- usr.sbin/syslogd/syslogd.8 (revision 314585) +++ usr.sbin/syslogd/syslogd.8 (working copy) @@ -131,7 +131,7 @@ .Ar service of .Ql \&* -allows packets to be received from any UDP port. +allows UDP packets to be sent with any source port. The default .Ar service is [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYuRgKAAoJEPWDqSZpMIYVmAoQAJGtg1OrJ8PlolGpH8TqPcbE QA3MB2uSO9azBwmpWH6Sthb1tHNodCIO4e8S/mW4g69DPuqeKm7U0CgrXIUEExWZ LWmGzMMIElRckLhNk9sOuTMbjxr+/E01X2Oh0mPJA+7M5Czaj2dra3BBSrNl/uWJ JIG7iphnddPHp26txiUaL1gAOneB8SuhzLO7dJbrfZFSEvGHpZ8XsTdH7zD1Y3hc NI2N3+LxEsVbstPPhulRGe7DU2wxMphmiYJ53/mVQ4HTou2E6OWjL++RcaH2Ddlp j1sDR10plceXxn8fVOjYiwyniX/rSRctM97iaWL0gVEnUOi3pnxOm/Rjo0gKcrwN isv0yFbKEmLBAknBK+NQsZEzsXDYCUUSGUxInEBRYLLS8Am+ks+SWnYYfCLgLqsW p6ZJEGPPuFCiUPTzngnKx16XulgUVgbVKSkmRoNgClrb75Jq28+DodYUCvc32zW1 BZ1W1RVUGMQfBebGlO9U7Cq4iYRGs7rgwqtBQd4uP/VW7LCi7iwpdq7mNg67I5kd 1l9bysTLkTH7R8VginWqCc5rmibygP1xKNPHYLGvnVnm5D1f1FxsqKgAUVhvAvZh CyzBu1uquNSdBTW8Mazp/WJ/fadqTuz083WesLtuYC/BT6Vt8GoIGEp0M4Gnv6yt e9w2ws4kgJK99CrDf+Hw =8eSm -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1A3F6606-822C-4C80-ADFA-48378F0F29EE>